You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/29 20:57:28 UTC

[GitHub] [kafka] ableegoldman edited a comment on pull request #10407: KAFKA-12523: handle TaskCorruption during handleCorruption and handleRevocation

ableegoldman edited a comment on pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#issuecomment-809707992


   Only one test failed during the last build, `shouldCloseAndReviveUncorruptedTasksWhenTimeoutExceptionThrownFromCommitDuringHandleCorruptedWithEOS`. This was due to a strict mock and interleaved ordering between task `0_0` and `0_1` -- after I un-strictified the mock it passed 200 iterations so I think it's safe to assume the problem has been resolved. Since this was the only change in the last commit, and this PR is currently blocking the 2.8 release, ~I'm going to move forward with merging this.~
   edit: just saw Guozhang left some comments, will address before merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org