[jira] [Commented] (HIVE-9565) Minor cleanup in TestMetastoreExpr.

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-9565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304776#comment-14304776 ] 

Hive QA commented on HIVE-9565:
-------------------------------



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12696264/HIVE-9565.1.patch

{color:green}SUCCESS:{color} +1 7422 tests passed

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2645/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2645/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2645/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12696264 - PreCommit-HIVE-TRUNK-Build

> Minor cleanup in TestMetastoreExpr.
> -----------------------------------
>
>                 Key: HIVE-9565
>                 URL: https://issues.apache.org/jira/browse/HIVE-9565
>             Project: Hive
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 0.14.0
>            Reporter: Mithun Radhakrishnan
>            Assignee: Mithun Radhakrishnan
>            Priority: Minor
>         Attachments: HIVE-9565.1.patch
>
>
> Here's some minor cleanup in TestMetastoreExpr.
> 0. There was an incomplete refactor in {{ExprBuilder.fn()}}, where the {{TypeInfo}} object was hard-coded to {{booleanTypeInfo}}.
> 1. I've removed the {{throws}} clauses for redundant exceptions.
> 2. Expected exceptions have been labelled as {{ignore}}.
> As an aside, that {{ExprBuilder}} is nifty. It's just the thing to exercise {{HiveMetastoreClient.listPartitionsByExpr()}}. I'm whacking this idea for an upcoming fix to {{HCatClient.dropPartitions()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)