You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/09/04 01:35:38 UTC

Re: Review Request 13903: Added a cgroups::memory namespace.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13903/#review25865
-----------------------------------------------------------

Ship it!



src/linux/cgroups.hpp
<https://reviews.apache.org/r/13903/#comment50431>

    const &



src/linux/cgroups.hpp
<https://reviews.apache.org/r/13903/#comment50432>

    const &


- Benjamin Hindman


On Aug. 31, 2013, 12:29 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13903/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2013, 12:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> I've adjusted the CgroupsIsolator code to use these new functions.
> 
> Note that this always sets the soft_limit_in_bytes. This should have been done in the first place, so let me know if you see a reason to conditionally set the soft limit as before.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 3989712b5b76bc960f03fdf020a4e5b735ba5d80 
>   src/linux/cgroups.cpp b97a89cafab12aa642645508ad465f714ee08f1b 
>   src/slave/cgroups_isolator.cpp 676768e6b8bd13820467309814845257a9c47e02 
> 
> Diff: https://reviews.apache.org/r/13903/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>