You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2019/05/12 01:17:37 UTC

[kudu-CR] [util] Introduce yaml-cpp to read config files

Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13294

to look at the new patch set (#5).

Change subject: [util] Introduce yaml-cpp to read config files
......................................................................

[util] Introduce yaml-cpp to read config files

KUDU-1948 notice that yaml is better than json when use it as a config
file.
yaml-cpp [https://github.com/jbeder/yaml-cpp] is the most popular C++
yaml library I can find on GitHub.
This patch introduce yaml-cpp into Kudu, do some simple wrap, and add
some unit tests.

Change-Id: I8ef58befaffbcc880e13fa6fec61b8e94a189b5a
---
M CMakeLists.txt
A cmake_modules/FindYaml.cmake
M src/kudu/util/CMakeLists.txt
A src/kudu/util/yamlreader-test.cc
A src/kudu/util/yamlreader.cc
A src/kudu/util/yamlreader.h
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
10 files changed, 463 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/13294/5
-- 
To view, visit http://gerrit.cloudera.org:8080/13294
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8ef58befaffbcc880e13fa6fec61b8e94a189b5a
Gerrit-Change-Number: 13294
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>