[PR] ARTEMIS-4571 race condition w/TTL impacting in-vm connections [activemq-artemis]

["jbertram (via GitHub)" <gi...@apache.org>]

jbertram opened a new pull request, #4745:
URL: https://github.com/apache/activemq-artemis/pull/4745

   There is a race condition between ConnectionEntry.ttl and FailureCheckAndFlushThread whereby an in-vm connection may get closed inadvertently due to a TTL timeout. This is because ConnectionEntry.ttl is initialized to 60000 and then later set to -1 upon the initial Ping. If this update happens at *just* the right time in FailureCheckAndFlushThread then the connection will be closed.
   
   The fix ensures that the ConnectionEntry.ttl is set to -1 for in-vm connections from the start. It also eliminates the possibility of the race in FailureCheckAndFlushThread.
   
   This fix is based on static analysis of the code. The timing window is just too small to contruct a reliable test. The failure has only been seen in the wild a handful of times.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ARTEMIS-4571 race condition w/TTL impacting in-vm connections [activemq-artemis]

["clebertsuconic (via GitHub)" <gi...@apache.org>]

clebertsuconic merged PR #4745:
URL: https://github.com/apache/activemq-artemis/pull/4745


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org