You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by ijokarumawak <gi...@git.apache.org> on 2017/12/19 05:22:02 UTC

[GitHub] nifi pull request #2351: NIFI-4707: S2SProvenanceReportingTask not returning...

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2351#discussion_r157666543
  
    --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting/SiteToSiteProvenanceReportingTask.java ---
    @@ -174,34 +177,47 @@ public void onUnscheduled() {
             return properties;
         }
     
    -    private Map<String,String> createComponentMap(final ProcessGroupStatus status) {
    -        final Map<String,String> componentMap = new HashMap<>();
    +    private ComponentMapHolder createComponentMap(final ProcessGroupStatus status) {
    --- End diff --
    
    This method probably should be in ProvenanceEventConsumer instead of each ReportingTask implementation so that other ReportingTasks can get benefits from it. How do you think?


---