You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Benjamin Mahler (JIRA)" <ji...@apache.org> on 2015/04/09 02:33:12 UTC
[jira] [Commented] (MESOS-2581) Document tips, best practices,
guidelines for doing code reviews.
[ https://issues.apache.org/jira/browse/MESOS-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486417#comment-14486417 ]
Benjamin Mahler commented on MESOS-2581:
----------------------------------------
Core of the change is here: https://reviews.apache.org/r/32998/
Some other cleanups in the chain:
https://reviews.apache.org/r/32995/
https://reviews.apache.org/r/32996/
https://reviews.apache.org/r/32997/
https://reviews.apache.org/r/32998/
https://reviews.apache.org/r/32999/
> Document tips, best practices, guidelines for doing code reviews.
> -----------------------------------------------------------------
>
> Key: MESOS-2581
> URL: https://issues.apache.org/jira/browse/MESOS-2581
> Project: Mesos
> Issue Type: Improvement
> Components: documentation, technical debt
> Reporter: Benjamin Mahler
> Assignee: Benjamin Mahler
> Labels: twitter
>
> We currently have a ["Committers Guide"|https://github.com/apache/mesos/blob/0.22.0/docs/committers-guide.md], however most of this information is relevant to all contributors looking to be participating in the code review process.
> I'm proposing we extract much of this information into a more general "Code Reviewing" document, and include additional tips, best practices, lessons learned from members of the community.
> This would be a great pre-requisite for on-boarding more committers and adding [MAINTAINERS|http://mail-archives.apache.org/mod_mbox/mesos-dev/201502.mbox/%3CCA+8RcoReugMVqoOpsnB8WGYBELa5fHwPA=J=YHJE22iwZvsbeQ@mail.gmail.com%3E].
> The committers guide can be more specific to our expectations of committers, so we may want to make this into a "committership" document to help set expectations for contributors looking to become committers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)