You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/08/06 19:03:43 UTC
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #815: DISPATCH-1744: refactor common HTTP code
kgiusti opened a new pull request #815:
URL: https://github.com/apache/qpid-dispatch/pull/815
Just a simple code reorg to move some of the configuration logic that is common to both versions of HTTP.
Do not bother with reviewing any of the http1_* files - these files are fairly old. I'll follow up with a PR as I flesh out the adaptor some.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #815: DISPATCH-1744: refactor common HTTP code
Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on a change in pull request #815:
URL: https://github.com/apache/qpid-dispatch/pull/815#discussion_r466655625
##########
File path: python/qpid_dispatch/management/qdrouter.json
##########
@@ -1103,6 +1103,16 @@
"required": false,
"description": "Name of the sslProfile..",
"create": true
+ },
+ "protocolVersion": {
+ "description": "The version of the HTTP protocol supported by this listener.",
+ "type": [
+ "HTTP/1.x",
+ "HTTP/2.0"
+ ],
+ "default": "HTTP/2.0",
Review comment:
Please default to HTTP/1.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #815: DISPATCH-1744: refactor common HTTP code
Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on pull request #815:
URL: https://github.com/apache/qpid-dispatch/pull/815#issuecomment-670170373
I have looked at the common part of this code and it looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #815: DISPATCH-1744: refactor common HTTP code
Posted by GitBox <gi...@apache.org>.
kgiusti closed pull request #815:
URL: https://github.com/apache/qpid-dispatch/pull/815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #815: DISPATCH-1744: refactor common HTTP code
Posted by GitBox <gi...@apache.org>.
kgiusti commented on pull request #815:
URL: https://github.com/apache/qpid-dispatch/pull/815#issuecomment-671516811
commit c20b29a1f70a507fd04a26b2d1692aa522fdb9b1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org