You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Ethan Lai (JIRA)" <ji...@apache.org> on 2012/10/27 16:29:11 UTC
[jira] [Created] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Ethan Lai created TS-1551:
-----------------------------
Summary: ssl_multicert.config not reread with traffic_line -x
Key: TS-1551
URL: https://issues.apache.org/jira/browse/TS-1551
Project: Traffic Server
Issue Type: Bug
Components: Configuration, SSL
Affects Versions: 3.2.0
Environment: RHEL 6
Reporter: Ethan Lai
Priority: Minor
Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
Just wondering is this expected behavior or not?
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
[Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
[Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
[Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
[Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
[Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
[Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
[Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
$ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
$ `trafflic_line -x`
[Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
[Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
[Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Attachment: (was: ssl_multicert_reconfigure.patch)
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reconfigure.patch
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488559#comment-13488559 ]
Ethan Lai commented on TS-1551:
-------------------------------
James, my implementation does not reload SSLConfigParams, it just use it for SSLCertLookup instance build.
About the refcount, this could prevent critical section between ctx was returned from SSLCertLookup table but a ReloadInstance() called just before SSL_new() use it. In this situation, SSL might refer a ctx already be freed. defaultContext() also should refer to a live ctx as well, and this refcount will be decrement just after calling SSL_new(). But since this SSLCert_FreerContinuation was delayed by at least 2 seconds, it might not be that necessary.
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reload.patch, ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Attachment: (was: ssl_multicert_reload.patch)
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "James Peach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach resolved TS-1551.
-----------------------------
Resolution: Fixed
Fix Version/s: 3.3.1
82144fbe108da4113ae0b460acb25a8c9a59b123 TS-1551: Move ProxyConfig down to libmgmt
b4816b089d79c429a858c214333c6a3ea0e7dfa2 TS-1551: use ConfigInfo rather than similar custom code
c63c4dd225d1fa05d2735d5a8b100d07cd80a29d TS-1551: reload ssl_multicert.config at runtime
Ethan, I made some additional changes after applying your patch. Can you please review and test, and let me know if there are any problems.
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Fix For: 3.3.1
>
> Attachments: ssl_multicert_reconfigure.patch
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Comment: was deleted
(was: James, sorry for just copying similar param codes from 3.2.0 patch, I've updated it.
About the refcount, I just use mutex instead. (not sure is this mutex ok or not)
Please find the attachment for the updated patch.)
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Attachment: (was: ssl_multicert_reload.patch-3.2.0)
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Attachment: ssl_multicert_reconfigure.patch
TS-1551: reload ssl_multicert.config after traffic_line -x
* use ConfigProcessor way to set/get/release SSLCertLookup objects
* remove (has)MultipleCerts since there were nowhere using it
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reconfigure.patch
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Attachment: (was: ssl_multicert_reload.patch)
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Comment: was deleted
(was: ssl_multicert_reload.patch for current git master
ssl_multicert_reload.patch-3.2.0 for trafficserver-3.2.0
TS-1551: reload ssl_multicert.config after traffic_line -x
* reconstruct SSLEntry to save wildcard names only, make ssl_storage the only ssl_ctx storage.
* ssl_default is now only for null ctx only(avoid crashing for SNI requests), the real default ctx should be found in ssl_storage with "*" key
* change sslCertLookup to pointer instead of static object, then replace pointer after reload)
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Attachment: ssl_multicert_reload.patch
TS-1551: reload ssl_multicert.config after traffic_line -x
* reconstruct SSLEntry to save wildcard names only, make ssl_storage the only ssl_ctx storage.
* ssl_default is now only for null ctx only(avoid crashing for SNI requests), the real default ctx should be found in ssl_storage with "*" key
* change sslCertLookup to pointer instead of static object, then replace pointer after reload
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reload.patch, ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Comment: was deleted
(was: TS-1551: reload ssl_multicert.config after traffic_line -x
* reconstruct SSLEntry to save wildcard names only, make ssl_storage the only ssl_ctx storage.
* ssl_default is now only for null ctx only(avoid crashing for SNI requests), the real default ctx should be found in ssl_storage with "*" key
* change sslCertLookup to pointer instead of static object, then replace pointer after reload)
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Attachment: ssl_multicert_reload.patch
James, sorry for just copying similar param codes from 3.2.0 patch, I've updated it.
About the refcount, I just use mutex instead.
Please find the attachment for the updated patch.
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reload.patch, ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (TS-1551) ssl_multicert.config not reread
with traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488559#comment-13488559 ]
Ethan Lai edited comment on TS-1551 at 11/1/12 8:57 AM:
--------------------------------------------------------
James, my implementation does not reload SSLConfigParams, it just use it for SSLCertLookup instance build.
About the refcount, this could prevent critical section between ctx was returned from SSLCertLookup table but a ReloadInstance() called just before SSL_new() use this ctx. In this situation, SSL_new() might refer a ctx already be freed. defaultContext() also should refer to a live ctx as well, and this refcount will be decrement just after calling SSL_new(). But since this SSLCert_FreerContinuation was delayed by at least 2 seconds, it might not be that necessary.
was (Author: yzlai):
James, my implementation does not reload SSLConfigParams, it just use it for SSLCertLookup instance build.
About the refcount, this could prevent critical section between ctx was returned from SSLCertLookup table but a ReloadInstance() called just before SSL_new() use this ctx. In this situation, SSL might refer a ctx already be freed. defaultContext() also should refer to a live ctx as well, and this refcount will be decrement just after calling SSL_new(). But since this SSLCert_FreerContinuation was delayed by at least 2 seconds, it might not be that necessary.
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reload.patch, ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Attachment: (was: ssl_multicert_reload.patch-3.2.0)
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Attachment: (was: ssl_multicert_reload.patch)
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "James Peach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach reassigned TS-1551:
-------------------------------
Assignee: James Peach
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reload.patch, ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Attachment: ssl_multicert_reload.patch-3.2.0
ssl_multicert_reload.patch
ssl_multicert_reload.patch for current git master
ssl_multicert_reload.patch-3.2.0 for trafficserver-3.2.0
TS-1551: reload ssl_multicert.config after traffic_line -x
* reconstruct SSLEntry to save wildcard names only, make ssl_storage the only ssl_ctx storage.
* ssl_default is now only for null ctx only(avoid crashing for SNI requests), the real default ctx should be found in ssl_storage with "*" key
* change sslCertLookup to pointer instead of static object, then replace pointer after reload
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reload.patch, ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Attachment: (was: ssl_multicert_reload.patch)
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (TS-1551) ssl_multicert.config not reread
with traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488559#comment-13488559 ]
Ethan Lai edited comment on TS-1551 at 11/1/12 8:57 AM:
--------------------------------------------------------
James, my implementation does not reload SSLConfigParams, it just use it for SSLCertLookup instance build.
About the refcount, this could prevent critical section between ctx was returned from SSLCertLookup table but a ReloadInstance() called just before SSL_new() use this ctx. In this situation, SSL might refer a ctx already be freed. defaultContext() also should refer to a live ctx as well, and this refcount will be decrement just after calling SSL_new(). But since this SSLCert_FreerContinuation was delayed by at least 2 seconds, it might not be that necessary.
was (Author: yzlai):
James, my implementation does not reload SSLConfigParams, it just use it for SSLCertLookup instance build.
About the refcount, this could prevent critical section between ctx was returned from SSLCertLookup table but a ReloadInstance() called just before SSL_new() use it. In this situation, SSL might refer a ctx already be freed. defaultContext() also should refer to a live ctx as well, and this refcount will be decrement just after calling SSL_new(). But since this SSLCert_FreerContinuation was delayed by at least 2 seconds, it might not be that necessary.
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reload.patch, ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Attachment: ssl_multicert_reload.patch-3.2.0
ssl_multicert_reload.patch
ssl_multicert_reload.patch for current git master
ssl_multicert_reload.patch-3.2.0 for trafficserver-3.2.0
TS-1551: reload ssl_multicert.config after traffic_line -x
* reconstruct SSLEntry to save wildcard names only, make ssl_storage the only ssl_ctx storage.
* ssl_default is now only for null ctx only(avoid crashing for SNI requests), the real default ctx should be found in ssl_storage with "*" key
* change sslCertLookup to pointer instead of static object, then replace pointer after reload
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Priority: Minor
> Attachments: ssl_multicert_reload.patch, ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "James Peach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488472#comment-13488472 ]
James Peach commented on TS-1551:
---------------------------------
Ethan, does the SSLConfigParams object get reloaded correctly? If you look at proxy/ProxyConfig.cc, there is an existing mechanism for reloading configuration (very similar to your implementation!). Do you think that this can also be used for SSCertLookup?
I'm not sure I get the need for setTobedestroyed(). It seems like the SSLCert_FreerContinuation should own the refcount and just decrement it. Having a live object with a zero refcount is a bit unconventional. I'm also a bit leery about defaultContext() sometimes taking a refcount ... is that ever dropped?
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Priority: Minor
> Attachments: ssl_multicert_reload.patch, ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Comment: was deleted
(was: James, my implementation does not reload SSLConfigParams, it just use it for SSLCertLookup instance build.
About the refcount, this could prevent critical section between ctx was returned from SSLCertLookup table but a ReloadInstance() called just before SSL_new() use this ctx. In this situation, SSL_new() might refer a ctx already be freed. defaultContext() also should refer to a live ctx as well, and this refcount will be decrement just after calling SSL_new(). But since this SSLCert_FreerContinuation was delayed by at least 2 seconds, it might not be that necessary.)
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reload.patch, ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488703#comment-13488703 ]
Ethan Lai commented on TS-1551:
-------------------------------
James, sorry for just copying similar param codes from 3.2.0 patch, I've updated it.
About the refcount, I just use mutex instead. (not sure is this mutex ok or not)
Please find the attachment for the updated patch.
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reload.patch, ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Attachment: ssl_multicert_reconfigure.patch
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reconfigure.patch
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1551) ssl_multicert.config not reread with
traffic_line -x
Posted by "Ethan Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Lai updated TS-1551:
--------------------------
Comment: was deleted
(was: James, sorry for just copying similar param codes from 3.2.0 patch, I've updated it.
About the refcount, I just use mutex instead.
Please find the attachment for the updated patch.)
> ssl_multicert.config not reread with traffic_line -x
> ----------------------------------------------------
>
> Key: TS-1551
> URL: https://issues.apache.org/jira/browse/TS-1551
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration, SSL
> Affects Versions: 3.2.0
> Environment: RHEL 6
> Reporter: Ethan Lai
> Assignee: James Peach
> Priority: Minor
> Attachments: ssl_multicert_reload.patch, ssl_multicert_reload.patch-3.2.0
>
>
> Found that "ssl_multicert.config" is marked as modified, but not reread while running traffic_line -x (Reread Config Files).
> Just wondering is this expected behavior or not?
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> [Oct 26 09:59:45.018] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::startProxy] Launching ts process
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [LocalManager::pollMgmtProcessServer] New process connecting fd '12'
> [Oct 26 09:59:45.025] Manager {0x7f3c6723d7e0} NOTE: [Alarms::signalAlarm] Server Process born
> [Oct 26 09:59:46.066] Server {0x2b500a320680} DEBUG: (ssl) ssl_multicert.config: /usr/local/etc/trafficserver/ssl_multicert.config
> [Oct 26 09:59:46.094] Server {0x2b500a320680} DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v2.pem
> [Oct 26 09:59:46.096] Server {0x2b500a320680} NOTE: logging initialized[15], logging_mode = 3
> [Oct 26 09:59:46.126] Server {0x2b500a320680} NOTE: traffic server running
> $ sed -i 's/j1.free888.cloudns.biz-v2/j1.free888.cloudns.biz-v3/' /usr/local/etc/trafficserver/ssl_multicert.config
> $ `trafflic_line -x`
> [Oct 26 09:59:59.954] Manager {0x7f3c5ffff700} DEBUG: (rollback) [Rollback::internalUpdate] Moving ssl_multicert.config from version 43 to version 44
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: [fileUpdated] ssl_multicert.config file has been modified
> [Oct 26 09:59:59.970] Manager {0x7f3c5ffff700} NOTE: User has changed config file ssl_multicert.config
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> No "DEBUG: (ssl) mapping 'j1.free888.cloudns.biz' to certificate /usr/local/etc/ats-cert/j1.free888.cloudns.biz-v3.pem" message found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira