You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by bo...@apache.org on 2026/01/13 18:50:18 UTC
(grails-core) 06/13: more fixes
This is an automated email from the ASF dual-hosted git repository.
borinquenkid pushed a commit to branch 8.0.x-hibernate7
in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit bc5cea779d9569272a304bf8b73cb26769ad0f89
Author: Walter B Duque de Estrada <bo...@users.noreply.github.com>
AuthorDate: Sat Jan 10 15:25:26 2026 -0600
more fixes
---
grails-data-hibernate7/core/HIBERNATE7-TESTS.csv | 2 --
.../hibernate/cfg/domainbinding/ManyToOneValuesBinderSpec.groovy | 8 ++++----
.../cfg/domainbinding/NaturalIdentifierBinderSpec.groovy | 1 +
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/grails-data-hibernate7/core/HIBERNATE7-TESTS.csv b/grails-data-hibernate7/core/HIBERNATE7-TESTS.csv
index 3c0c681e6a..34321d02db 100644
--- a/grails-data-hibernate7/core/HIBERNATE7-TESTS.csv
+++ b/grails-data-hibernate7/core/HIBERNATE7-TESTS.csv
@@ -4,8 +4,6 @@
`src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/SimpleValueBinderSpec.groovy` , FAILED , Generator binding issues.
`src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/CascadeBehaviorPersisterSpec.groovy` , FAILED , Unsupported cascade style: save-update.
`src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/CascadeBehaviorFetcherSpec.groovy` , FAILED , Expected save-update but got all.
- `src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/ManyToOneValuesBinderSpec.groovy` , FAILED , Final class org.hibernate.mapping.ManyToOne cannot be mocked.
- `src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/NaturalIdentifierBinderSpec.groovy` , FAILED , Final/Sealed class issues with RootClass and Column.
`src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/ColumnBinderSpec.groovy` , FAILED ," Column name mismatch: got ""test"" instead of expected. "
`src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/IndexBinderSpec.groovy` , FAILED , Sealed class org.hibernate.mapping.Column cannot be mocked.
`src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/NamespaceNameExtractorSpec.groovy` , FAILED , Final class org.hibernate.boot.model.relational.Namespace$Name cannot be mocked.
diff --git a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/ManyToOneValuesBinderSpec.groovy b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/ManyToOneValuesBinderSpec.groovy
index 91538e7def..f58b5a19d4 100644
--- a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/ManyToOneValuesBinderSpec.groovy
+++ b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/ManyToOneValuesBinderSpec.groovy
@@ -40,10 +40,10 @@ class ManyToOneValuesBinderSpec extends HibernateGormDatastoreSpec {
then:
// 5. Verify that the correct values were set on the ManyToOne object
- 1 * manyToOne.setFetchMode(expectedFetchMode)
- 1 * manyToOne.setLazy(expectedLazy)
- 1 * manyToOne.setIgnoreNotFound(testIgnoreNotFound)
- 1 * manyToOne.setReferencedEntityName("AssociatedEntityName")
+ manyToOne.getFetchMode() == expectedFetchMode
+ manyToOne.isLazy() == expectedLazy
+ manyToOne.isIgnoreNotFound() == testIgnoreNotFound
+ manyToOne.getReferencedEntityName() == "AssociatedEntityName"
where:
scenario | testFetchMode | testLazy | testIgnoreNotFound | expectedFetchMode | expectedLazy
diff --git a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/NaturalIdentifierBinderSpec.groovy b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/NaturalIdentifierBinderSpec.groovy
index 0c58e59fbd..cc0ea00a6a 100644
--- a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/NaturalIdentifierBinderSpec.groovy
+++ b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/cfg/domainbinding/NaturalIdentifierBinderSpec.groovy
@@ -36,6 +36,7 @@ class NaturalIdentifierBinderSpec extends HibernateGormDatastoreSpec {
rootClass.setIdentifierProperty(property)
rootClass.setTable(table)
value.getSelectables() >> []
+ value.hasAnyUpdatableColumns() >> isMutable
def uniqueNameGenerator = Mock(UniqueNameGenerator)
def binder = new NaturalIdentifierBinder(uniqueNameGenerator)