You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/07/18 22:10:52 UTC
[GitHub] [helix] qqu0127 opened a new pull request, #2177: Add TASK_THREADPOOL_RESET_TIMEOUT as system property
qqu0127 opened a new pull request, #2177:
URL: https://github.com/apache/helix/pull/2177
Allow users to specify reset timeout with system property.
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fix https://github.com/apache/helix/issues/2175
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Add a new system property `TASK_THREADPOOL_RESET_TIMEOUT` so that users can set to specify the timeout limit for reseting the task threadpool.
The timeout was introduced in https://github.com/apache/helix/pull/1920, but users wouldn't be able to set it unless they have access to `DefaultMessagingService`.
### Tests
- [X] The following tests are written for this issue:
TestDefaultMessagingService.testTaskThreadpoolResetTimeoutProperty
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on pull request #2177: Add TASK_THREADPOOL_RESET_TIMEOUT as system property
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on PR #2177:
URL: https://github.com/apache/helix/pull/2177#issuecomment-1189640382
This PR is ready to merge, approved by @desaikomal
Commit message:
Add TASK_THREADPOOL_RESET_TIMEOUT as system property
Allow users to specify reset timeout with system property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a diff in pull request #2177: Add TASK_THREADPOOL_RESET_TIMEOUT as system property
Posted by GitBox <gi...@apache.org>.
desaikomal commented on code in PR #2177:
URL: https://github.com/apache/helix/pull/2177#discussion_r924771281
##########
helix-common/src/main/java/org/apache/helix/SystemPropertyKeys.java:
##########
@@ -34,6 +34,9 @@ public class SystemPropertyKeys {
// Task Driver
public static final String TASK_CONFIG_LIMITATION = "helixTask.configsLimitation";
+ // Task executor threadpool reset timeout in ms
+ public static final String TASK_THREADPOOL_RESET_TIMEOUT = "helixTask.threadpool.reset.timeout";
Review Comment:
nit - suggestion - helixTask.threadpool.resetTimeout (camel casing is done for others)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on a diff in pull request #2177: Add TASK_THREADPOOL_RESET_TIMEOUT as system property
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on code in PR #2177:
URL: https://github.com/apache/helix/pull/2177#discussion_r924776511
##########
helix-common/src/main/java/org/apache/helix/SystemPropertyKeys.java:
##########
@@ -34,6 +34,9 @@ public class SystemPropertyKeys {
// Task Driver
public static final String TASK_CONFIG_LIMITATION = "helixTask.configsLimitation";
+ // Task executor threadpool reset timeout in ms
+ public static final String TASK_THREADPOOL_RESET_TIMEOUT = "helixTask.threadpool.reset.timeout";
Review Comment:
Done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #2177: Add TASK_THREADPOOL_RESET_TIMEOUT as system property
Posted by GitBox <gi...@apache.org>.
junkaixue merged PR #2177:
URL: https://github.com/apache/helix/pull/2177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org