You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by cw...@apache.org on 2011/09/23 19:09:13 UTC

svn commit: r1174888 - /uima/uima-as/trunk/uimaj-as-jms/src/main/java/org/apache/uima/adapter/jms/client/BaseUIMAAsynchronousEngineCommon_impl.java

Author: cwiklik
Date: Fri Sep 23 17:09:12 2011
New Revision: 1174888

URL: http://svn.apache.org/viewvc?rev=1174888&view=rev
Log:
UIMA-2232 fix a bug reported by Findbugs - possible null dereference

Modified:
    uima/uima-as/trunk/uimaj-as-jms/src/main/java/org/apache/uima/adapter/jms/client/BaseUIMAAsynchronousEngineCommon_impl.java

Modified: uima/uima-as/trunk/uimaj-as-jms/src/main/java/org/apache/uima/adapter/jms/client/BaseUIMAAsynchronousEngineCommon_impl.java
URL: http://svn.apache.org/viewvc/uima/uima-as/trunk/uimaj-as-jms/src/main/java/org/apache/uima/adapter/jms/client/BaseUIMAAsynchronousEngineCommon_impl.java?rev=1174888&r1=1174887&r2=1174888&view=diff
==============================================================================
--- uima/uima-as/trunk/uimaj-as-jms/src/main/java/org/apache/uima/adapter/jms/client/BaseUIMAAsynchronousEngineCommon_impl.java (original)
+++ uima/uima-as/trunk/uimaj-as-jms/src/main/java/org/apache/uima/adapter/jms/client/BaseUIMAAsynchronousEngineCommon_impl.java Fri Sep 23 17:09:12 2011
@@ -2121,12 +2121,14 @@ public abstract class BaseUIMAAsynchrono
     	            		serviceDelegate.getOldestCasIdFromOutstandingList();
     	        	if ( nextOutstandingCasReferenceId != null ) {
     	        		cachedRequest = (ClientRequest) clientCache.get(nextOutstandingCasReferenceId);
-    	        		try {
-    	            		sendCAS(cachedRequest.getCAS());
-    	        		} catch( Exception e) {
-    	        			UIMAFramework.getLogger(CLASS_NAME).logrb(Level.WARNING, getClass().getName(),
-    	                            "notifyOnTimout", UIMAEE_Constants.JMS_LOG_RESOURCE_BUNDLE,
-    	                            "UIMAEE_exception__WARNING", e);
+    	        		if ( cachedRequest != null && cachedRequest.getCAS() != null ) {
+        	        		try {
+        	            		sendCAS(cachedRequest.getCAS());
+        	        		} catch( Exception e) {
+        	        			UIMAFramework.getLogger(CLASS_NAME).logrb(Level.WARNING, getClass().getName(),
+        	                            "notifyOnTimout", UIMAEE_Constants.JMS_LOG_RESOURCE_BUNDLE,
+        	                            "UIMAEE_exception__WARNING", e);
+        	        		}
     	        		}
     	        	}
     	        }