[GitHub] [tvm] leandron commented on a change in pull request #7658: [TVMC][TensorRT] Enable TensorRT target through TVMC

[GitBox <gi...@apache.org>]

leandron commented on a change in pull request #7658:
URL: https://github.com/apache/tvm/pull/7658#discussion_r643027119



##########
File path: python/tvm/driver/tvmc/compiler.py
##########
@@ -196,9 +196,9 @@ def compile_model(
     for codegen_from_cli in extra_targets:
         codegen = composite_target.get_codegen_by_target(codegen_from_cli["name"])
         partition_function = codegen["pass_pipeline"]
-        mod = partition_function(mod, params)
+        mod, codegen_config = partition_function(mod, params)

Review comment:
       Yeah, I agree this is simpler and effective from now. Happy to approve once we get the linting issues sorted out and CI passing here.

##########
File path: python/tvm/driver/tvmc/compiler.py
##########
@@ -196,9 +196,9 @@ def compile_model(
     for codegen_from_cli in extra_targets:
         codegen = composite_target.get_codegen_by_target(codegen_from_cli["name"])
         partition_function = codegen["pass_pipeline"]
-        mod = partition_function(mod, params)
+        mod, codegen_config = partition_function(mod, params)

Review comment:
       Yeah, I agree this is simpler and effective for now. Happy to approve once we get the linting issues sorted out and CI passing here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org