You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "FrankYang0529 (via GitHub)" <gi...@apache.org> on 2026/06/18 10:56:11 UTC
[PR] Fix GlueJobHook failing to update a Glue job that has tags [airflow]
FrankYang0529 opened a new pull request, #68711:
URL: https://github.com/apache/airflow/pull/68711
When `GlueJobOperator` / `GlueJobHook` runs with `update_config=True` against a job that already exists and whose `create_job_kwargs` include `Tags`, the update fails.
AWS Glue's [`CreateJob`](https://docs.aws.amazon.com/glue/latest/webapi/API_CreateJob.html)
accepts a top-level `Tags` parameter, but [`UpdateJob`](https://docs.aws.amazon.com/glue/latest/webapi/API_UpdateJob.html) only accepts `JobName` and a `JobUpdate` structure. The hook passed the whole config (including `Tags`) straight into `JobUpdate`, so botocore rejected the call with a `ParamValidationError`. The result was an inconsistency: tagging a job worked on first creation but broke on every subsequent update.
This strips `Tags` out of the `JobUpdate` payload and reconciles them through the dedicated tag APIs ([`TagResource`](https://docs.aws.amazon.com/glue/latest/webapi/API_TagResource.html) / [`UntagResource`](https://docs.aws.amazon.com/glue/latest/webapi/API_UntagResource.html)), mirroring how `GlueCrawlerHook` already handles the same Glue limitation for crawlers. Tag additions, value changes, and removals are all applied. The `update_job` now reports that an update happened, when only the tags change.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
closes: #68676
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [X] Yes (please specify the tool below)
Generated-by: [Claude Code with Opus 4.8] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GlueJobHook failing to update a Glue job that has tags [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #68711:
URL: https://github.com/apache/airflow/pull/68711#discussion_r3437166746
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/glue.py:
##########
@@ -495,7 +498,37 @@ def update_job(self, **job_kwargs) -> bool:
self.conn.update_job(JobName=job_name, JobUpdate=job_kwargs)
self.log.info("Updated configurations: %s", update_config)
return True
- return False
+ return tags_updated
+
+ def update_tags(self, job_name: str, job_tags: dict) -> bool:
+ """
+ Reconcile a job's tags with the desired set.
+
+ Glue manages tags outside of ``update_job``, so adds/updates go through
+ ``tag_resource`` and removals through ``untag_resource``.
+
+ .. seealso::
+ - :external+boto3:py:meth:`Glue.Client.tag_resource`
+ - :external+boto3:py:meth:`Glue.Client.untag_resource`
+
+ :param job_name: Name of the job for which to update tags
+ :param job_tags: Desired tags. Keys absent from this mapping are removed from the job.
+ :return: True if any tag was added, changed, or removed, False otherwise
+ """
+ account_number = StsHook(aws_conn_id=self.aws_conn_id).get_account_number()
+ job_arn = f"arn:{self.conn_partition}:glue:{self.conn_region_name}:{account_number}:job/{job_name}"
+ current_tags: dict = self.conn.get_tags(ResourceArn=job_arn)["Tags"]
+
+ tags_to_add = {key: value for key, value in job_tags.items() if current_tags.get(key) != value}
+ tags_to_remove = [key for key in current_tags if key not in job_tags]
+
+ if tags_to_add:
+ self.log.info("Updating job tags: %s", job_name)
+ self.conn.tag_resource(ResourceArn=job_arn, TagsToAdd=tags_to_add)
+ if tags_to_remove:
+ self.log.info("Removing job tags: %s", job_name)
+ self.conn.untag_resource(ResourceArn=job_arn, TagsToRemove=tags_to_remove)
Review Comment:
```suggestion
if (tags_to_add := {key: value for key, value in job_tags.items() if current_tags.get(key) != value})
self.log.info("Updating job tags: %s", job_name)
self.conn.tag_resource(ResourceArn=job_arn, TagsToAdd=tags_to_add)
if (tags_to_remove := [key for key in current_tags if key not in job_tags])
self.log.info("Removing job tags: %s", job_name)
self.conn.untag_resource(ResourceArn=job_arn, TagsToRemove=tags_to_remove)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GlueJobHook failing to update a Glue job that has tags [airflow]
Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on PR #68711:
URL: https://github.com/apache/airflow/pull/68711#issuecomment-4749187156
@Lee-W Thanks for the review. I addressed all comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GlueJobHook failing to update a Glue job that has tags [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W merged PR #68711:
URL: https://github.com/apache/airflow/pull/68711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org