[GitHub] [spark] cloud-fan commented on a diff in pull request #38604: [SPARK-41102][CONNECT] Merge SparkConnectPlanner and SparkConnectCommandPlanner

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #38604:
URL: https://github.com/apache/spark/pull/38604#discussion_r1019837777


##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamHandler.scala:
##########
@@ -50,9 +49,9 @@ class SparkConnectStreamHandler(responseObserver: StreamObserver[Response]) exte
 
   def handlePlan(session: SparkSession, request: proto.Request): Unit = {

Review Comment:
   Commands can return rows, for example, `SHOW TABLES`. Even for DML commands, we may also return rows in the future, to include metrics (num rows inserted, etc.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org