[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10476: Feature DCS supports global configuration

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #10476:
URL: https://github.com/apache/skywalking/pull/10476#discussion_r1125459434


##########
oap-server/server-receiver-plugin/configuration-discovery-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/recevier/configuration/discovery/AgentConfigurationsReader.java:
##########
@@ -54,6 +54,9 @@ public AgentConfigurationsTable readAgentConfigurationsTable() {
                 if (configurationsData != null) {
                     configurationsData.forEach((k, v) -> {
                         Map map = (Map) v;
+                        if (configurationsData.containsKey("default-config")) {
+                            ((Map) configurationsData.get("default-config")).forEach(map::putIfAbsent);
+                        }

Review Comment:
   I am confused about this part. As `default-config` is a reserved key, and it shares the same structure as other services. Why do we have to change the init logic?
   Also, we don't build `agentConfigurationsTable` properly(no UUID part). 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org