You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Albert Strasheim <13...@sun.ac.za> on 2007/06/21 02:25:09 UTC

ActiveMQ vs FindBugs

Hello all,

I just ran some parts of ActiveMQ 5.0-SNAPSHOT through FindBugs 1.2.1 
and there's definitely some issues that deserve a closer look.

Any suggestions on how we could proceed to triage these issues?

Regards,

Albert

Re: ActiveMQ vs FindBugs

Posted by James Strachan <ja...@gmail.com>.
On 6/25/07, James Strachan <ja...@gmail.com> wrote:
> On 6/23/07, Albert Strasheim <fu...@gmail.com> wrote:
> > Hello all
> >
> > ----- Original Message -----
> > From: "James Strachan" <ja...@gmail.com>
> > To: <de...@activemq.apache.org>
> > Sent: Thursday, June 21, 2007 8:23 AM
> > Subject: Re: ActiveMQ vs FindBugs
> >
> >
> > > On 6/21/07, Albert Strasheim <13...@sun.ac.za> wrote:
> > >> Hello all,
> > >>
> > >> I just ran some parts of ActiveMQ 5.0-SNAPSHOT through FindBugs 1.2.1
> > >> and there's definitely some issues that deserve a closer look.
> > >>
> > >> Any suggestions on how we could proceed to triage these issues?
> > >
> > > Getting an automated FindBugs report as part of the 'mvn site' goal
> > > would be great; so we've the latest & greatest findbugs report online.
> >
> > I think we can start with just activemq-core to help us figure out which
> > warnings we're interested in. Adding the following to <plugins> in
> > activemq-core/pom.xml seems to do the trick:
> >
> > <plugin>
> >      <groupId>org.codehaus.mojo</groupId>
> >      <artifactId>findbugs-maven-plugin</artifactId>
> >      <version>1.1</version>
> >      <configuration>
> >        <threshold>Normal</threshold>
> >        <effort>Default</effort>
> >      </configuration>
> > </plugin>
> >
> > James, could you check this in?
>
> I'm assuming you meant in the <reporting/> element right? If so done
>
> > Where does one access ActiveMQ's Maven-generated site?
>
> Its here...
> http://activemq.apache.org/maven/
>
> or for the activemq-core module...
> http://activemq.apache.org/maven/activemq-core/index.html
>
> I've just manually kicked off the nightly site build, so in an hour or
> so it should be updated

Here you go...
http://activemq.apache.org/maven/activemq-core/findbugs.html

this report is created daily now.

-- 
James
-------
http://macstrac.blogspot.com/

Re: ActiveMQ vs FindBugs

Posted by James Strachan <ja...@gmail.com>.
On 6/23/07, Albert Strasheim <fu...@gmail.com> wrote:
> Hello all
>
> ----- Original Message -----
> From: "James Strachan" <ja...@gmail.com>
> To: <de...@activemq.apache.org>
> Sent: Thursday, June 21, 2007 8:23 AM
> Subject: Re: ActiveMQ vs FindBugs
>
>
> > On 6/21/07, Albert Strasheim <13...@sun.ac.za> wrote:
> >> Hello all,
> >>
> >> I just ran some parts of ActiveMQ 5.0-SNAPSHOT through FindBugs 1.2.1
> >> and there's definitely some issues that deserve a closer look.
> >>
> >> Any suggestions on how we could proceed to triage these issues?
> >
> > Getting an automated FindBugs report as part of the 'mvn site' goal
> > would be great; so we've the latest & greatest findbugs report online.
>
> I think we can start with just activemq-core to help us figure out which
> warnings we're interested in. Adding the following to <plugins> in
> activemq-core/pom.xml seems to do the trick:
>
> <plugin>
>      <groupId>org.codehaus.mojo</groupId>
>      <artifactId>findbugs-maven-plugin</artifactId>
>      <version>1.1</version>
>      <configuration>
>        <threshold>Normal</threshold>
>        <effort>Default</effort>
>      </configuration>
> </plugin>
>
> James, could you check this in?

I'm assuming you meant in the <reporting/> element right? If so done

> Where does one access ActiveMQ's Maven-generated site?

Its here...
http://activemq.apache.org/maven/

or for the activemq-core module...
http://activemq.apache.org/maven/activemq-core/index.html

I've just manually kicked off the nightly site build, so in an hour or
so it should be updated

-- 
James
-------
http://macstrac.blogspot.com/

Re: ActiveMQ vs FindBugs

Posted by Albert Strasheim <fu...@gmail.com>.
Hello all

----- Original Message ----- 
From: "James Strachan" <ja...@gmail.com>
To: <de...@activemq.apache.org>
Sent: Thursday, June 21, 2007 8:23 AM
Subject: Re: ActiveMQ vs FindBugs


> On 6/21/07, Albert Strasheim <13...@sun.ac.za> wrote:
>> Hello all,
>>
>> I just ran some parts of ActiveMQ 5.0-SNAPSHOT through FindBugs 1.2.1
>> and there's definitely some issues that deserve a closer look.
>>
>> Any suggestions on how we could proceed to triage these issues?
>
> Getting an automated FindBugs report as part of the 'mvn site' goal
> would be great; so we've the latest & greatest findbugs report online.

I think we can start with just activemq-core to help us figure out which 
warnings we're interested in. Adding the following to <plugins> in 
activemq-core/pom.xml seems to do the trick:

<plugin>
     <groupId>org.codehaus.mojo</groupId>
     <artifactId>findbugs-maven-plugin</artifactId>
     <version>1.1</version>
     <configuration>
       <threshold>Normal</threshold>
       <effort>Default</effort>
     </configuration>
</plugin>

James, could you check this in?

Where does one access ActiveMQ's Maven-generated site?

Cheers,

Albert


Re: ActiveMQ vs FindBugs

Posted by James Strachan <ja...@gmail.com>.
On 6/21/07, Albert Strasheim <13...@sun.ac.za> wrote:
> Hello all,
>
> I just ran some parts of ActiveMQ 5.0-SNAPSHOT through FindBugs 1.2.1
> and there's definitely some issues that deserve a closer look.
>
> Any suggestions on how we could proceed to triage these issues?

Getting an automated FindBugs report as part of the 'mvn site' goal
would be great; so we've the latest & greatest findbugs report online.

Then we can raise JIRAs on particular issues
-- 
James
-------
http://macstrac.blogspot.com/