You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2022/10/10 12:58:20 UTC
[GitHub] [curator] XComp opened a new pull request, #436: [CURATOR-653] Proposed changes based on PR #398
XComp opened a new pull request, #436:
URL: https://github.com/apache/curator/pull/436
This PR is based on PR #398 and adds a few comments from [my review of that PR](https://github.com/apache/curator/pull/398#pullrequestreview-1134363474)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] XComp commented on pull request #436: [CURATOR-653] Proposed changes based on PR #398
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #436:
URL: https://github.com/apache/curator/pull/436#issuecomment-1275765883
The timeout of {{TestPathChildrenCache}} in the [Java 11 CI job](https://github.com/apache/curator/actions/runs/3219514422/jobs/5264980959#step:6:1595) seems to be unrelated to this PR's change: It doesn't utilize `LeaderLatch` as far as I can see. I created CURATOR-657 to cover this test instability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun merged pull request #436: [CURATOR-653] Proposed changes based on PR #398
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #436:
URL: https://github.com/apache/curator/pull/436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] XComp commented on pull request #436: [CURATOR-653] Proposed changes based on PR #398
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #436:
URL: https://github.com/apache/curator/pull/436#issuecomment-1273457971
```
2022-10-10T13:50:53.7756841Z [INFO] Running org.apache.curator.framework.recipes.cache.TestPathChildrenCache
2022-10-10T15:00:44.1920989Z ##[error]The operation was canceled.
```
hm, looks like CI ran into a timeout exceeding the maximum threshold for a CI run of 120min due to `TestPathChildrenCache` :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #436: [CURATOR-653] Proposed changes based on PR #398
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #436:
URL: https://github.com/apache/curator/pull/436#issuecomment-1282147354
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org