You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/14 21:45:10 UTC
[GitHub] [arrow] Dandandan opened a new pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Dandandan opened a new pull request #9206:
URL: https://github.com/apache/arrow/pull/9206
Those have some impact on the performance of queries.
--features "":
```
Query 5 iteration 0 took 655.3 ms
Query 5 iteration 1 took 648.9 ms
Query 5 iteration 2 took 640.3 ms
Query 5 iteration 3 took 658.7 ms
Query 5 iteration 4 took 646.3 ms
Query 5 iteration 5 took 684.1 ms
Query 5 iteration 6 took 642.8 ms
Query 5 iteration 7 took 656.9 ms
Query 5 iteration 8 took 646.0 ms
Query 5 iteration 9 took 669.1 ms
Query 5 avg time: 654.85 ms
```
--features "snmalloc"
```
Query 5 iteration 0 took 525.4 ms
Query 5 iteration 1 took 478.8 ms
Query 5 iteration 2 took 485.7 ms
Query 5 iteration 3 took 486.6 ms
Query 5 iteration 4 took 482.6 ms
Query 5 iteration 5 took 473.1 ms
Query 5 iteration 6 took 494.4 ms
Query 5 iteration 7 took 483.5 ms
Query 5 iteration 8 took 493.1 ms
Query 5 iteration 9 took 479.4 ms
Query 5 avg time: 488.26 ms
```
--features ""
```
Query 12 iteration 0 took 241.4 ms
Query 12 iteration 1 took 234.8 ms
Query 12 iteration 2 took 229.8 ms
Query 12 iteration 3 took 229.5 ms
Query 12 iteration 4 took 228.3 ms
Query 12 iteration 5 took 230.0 ms
Query 12 iteration 6 took 228.3 ms
Query 12 iteration 7 took 229.3 ms
Query 12 iteration 8 took 229.9 ms
Query 12 iteration 9 took 230.1 ms
Query 12 avg time: 231.13 ms
```
--features "simd"
```
Query 12 iteration 0 took 157.7 ms
Query 12 iteration 1 took 159.3 ms
Query 12 iteration 2 took 156.9 ms
Query 12 iteration 3 took 163.0 ms
Query 12 iteration 4 took 157.5 ms
Query 12 iteration 5 took 157.6 ms
Query 12 iteration 6 took 156.6 ms
Query 12 iteration 7 took 157.4 ms
Query 12 iteration 8 took 158.6 ms
Query 12 iteration 9 took 157.0 ms
Query 12 avg time: 158.16 ms
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-760508710
A further option that can have bigger impact is by adding
```
[profile.release]
lto = true
```
to the project using DataFusion. But I am not sure if we can conditionally enable this (also it makes the build times very slow, but I think it makes sense to use for distributed binaries).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-761773160
I apologize for the delay in merging Rust PRs -- the 3.0 release is being finalized now and are planning to minimize entropy by postponing merging changes not critical for the release until the process was complete. I hope the process is complete in the next few days. There is more [discussion](https://lists.apache.org/list.html?dev@arrow.apache.org) in the mailing list
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-760520670
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=h1) Report
> Merging [#9206](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=desc) (7c9c349) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9206 +/- ##
=======================================
Coverage 81.61% 81.61%
=======================================
Files 215 215
Lines 51867 51891 +24
=======================================
+ Hits 42329 42353 +24
Misses 9538 9538
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/benchmarks/src/bin/nyctaxi.rs](https://codecov.io/gh/apache/arrow/pull/9206/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vbnljdGF4aS5ycw==) | `0.00% <ø> (ø)` | |
| [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/9206/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `12.18% <ø> (ø)` | |
| [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9206/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.66% <0.00%> (+0.16%)` | :arrow_up: |
| [rust/arrow/src/array/transform/fixed\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9206/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2ZpeGVkX2JpbmFyeS5ycw==) | `84.21% <0.00%> (+5.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=footer). Last update [4e1c3bb...7c9c349](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-760515611
For completeness, here is query 5 with simd + snmalloc + lto enabled:
```
Query 5 iteration 0 took 460.2 ms
Query 5 iteration 1 took 439.2 ms
Query 5 iteration 2 took 436.8 ms
Query 5 iteration 3 took 425.2 ms
Query 5 iteration 4 took 434.0 ms
Query 5 iteration 5 took 429.6 ms
Query 5 iteration 6 took 430.3 ms
Query 5 iteration 7 took 422.6 ms
Query 5 iteration 8 took 423.8 ms
Query 5 iteration 9 took 424.2 ms
Query 5 avg time: 432.59 ms
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan edited a comment on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
Dandandan edited a comment on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-760514799
> Wow 654.85 -> 118.09 is huge.
No unfortunately, Q12 runs finishes ~230ms on master. But still 230 -> 118 is a factor 1.95 :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-760509131
https://issues.apache.org/jira/browse/ARROW-11254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-760520670
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=h1) Report
> Merging [#9206](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=desc) (6ba139f) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9206 +/- ##
=======================================
Coverage 81.61% 81.61%
=======================================
Files 215 215
Lines 51867 51867
=======================================
Hits 42329 42329
Misses 9538 9538
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/benchmarks/src/bin/nyctaxi.rs](https://codecov.io/gh/apache/arrow/pull/9206/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vbnljdGF4aS5ycw==) | `0.00% <ø> (ø)` | |
| [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/9206/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `12.18% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=footer). Last update [4e1c3bb...defdf92](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-760513258
@seddonm1
Query 12, with lto + simd + snmalloc:
```
Query 12 iteration 0 took 118.8 ms
Query 12 iteration 1 took 118.7 ms
Query 12 iteration 2 took 118.3 ms
Query 12 iteration 3 took 117.0 ms
Query 12 iteration 4 took 117.7 ms
Query 12 iteration 5 took 118.9 ms
Query 12 iteration 6 took 117.9 ms
Query 12 iteration 7 took 118.1 ms
Query 12 iteration 8 took 117.7 ms
Query 12 iteration 9 took 117.8 ms
Query 12 avg time: 118.09 ms
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] seddonm1 commented on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-760500286
Cool. Maybe you could add the instructions to the readme?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#discussion_r557871555
##########
File path: rust/benchmarks/Cargo.toml
##########
@@ -26,11 +26,16 @@ repository = "https://github.com/apache/arrow"
license = "Apache-2.0"
publish = false
+[features]
+simd = ["datafusion/simd"]
+snmalloc = ["snmalloc-rs"]
+
[dependencies]
arrow = { path = "../arrow" }
parquet = { path = "../parquet" }
datafusion = { path = "../datafusion" }
structopt = { version = "0.3", default-features = false }
tokio = { version = "0.2", features = ["macros", "rt-core", "rt-threaded"] }
futures = "0.3"
-env_logger = "^0.8"
\ No newline at end of file
+env_logger = "^0.8"
+snmalloc-rs = {version = "0.2", optional = true }
Review comment:
nit: add line ending
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-760514799
> Wow 654.85 -> 118.09 is huge.
No unfortunately Q12 runs finishes ~230ms on master. But still 230 -> 118 is a factor 1.95 :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] seddonm1 commented on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-760512330
> A further option that can have bigger impact is by adding
>
> ```
> [profile.release]
> lto = true
> ```
>
> to the project using DataFusion. But I am not sure if we can conditionally enable this (also it makes the build times very slow, but I think it makes sense to use for distributed binaries).
I just read about this optimisation. What sort of performance are you seeing with it enabled (and simd)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-760520670
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=h1) Report
> Merging [#9206](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=desc) (4d5d11a) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9206 +/- ##
==========================================
- Coverage 81.61% 81.60% -0.01%
==========================================
Files 215 215
Lines 51867 51867
==========================================
- Hits 42329 42328 -1
- Misses 9538 9539 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/benchmarks/src/bin/nyctaxi.rs](https://codecov.io/gh/apache/arrow/pull/9206/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vbnljdGF4aS5ycw==) | `0.00% <ø> (ø)` | |
| [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/9206/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `12.18% <ø> (ø)` | |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9206/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `94.86% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=footer). Last update [4e1c3bb...4d5d11a](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9206:
URL: https://github.com/apache/arrow/pull/9206
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] seddonm1 commented on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-760518692
> > Wow 654.85 -> 118.09 is huge.
>
> No unfortunately, Q12 runs finishes ~230ms on master. But still 230 -> 118 is a factor 1.95 :)
Oh sorry I miss read it. Yes, I will happily take 230 -> 118 especially as the current option is Spark which hasn't even started the JVM for multiple seconds after this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-760520670
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=h1) Report
> Merging [#9206](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=desc) (defdf92) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9206 +/- ##
==========================================
- Coverage 81.61% 81.60% -0.01%
==========================================
Files 215 215
Lines 51867 51867
==========================================
- Hits 42329 42328 -1
- Misses 9538 9539 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/benchmarks/src/bin/nyctaxi.rs](https://codecov.io/gh/apache/arrow/pull/9206/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vbnljdGF4aS5ycw==) | `0.00% <ø> (ø)` | |
| [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/9206/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `12.18% <ø> (ø)` | |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9206/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `94.86% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=footer). Last update [4e1c3bb...defdf92](https://codecov.io/gh/apache/arrow/pull/9206?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] seddonm1 commented on pull request #9206: ARROW-11254: [Rust][DataFusion] Add SIMD and snmalloc flags as options to benchmarks
Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #9206:
URL: https://github.com/apache/arrow/pull/9206#issuecomment-760513979
Wow 654.85 -> 118.09 is huge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org