You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2024/02/29 02:47:18 UTC
[PR] [SPARK-47221][SQL] Uses signatures from CsvParser to AbstractParser [spark]
HyukjinKwon opened a new pull request, #45328:
URL: https://github.com/apache/spark/pull/45328
### What changes were proposed in this pull request?
This PR proposes to change signature `CsvParser` to `AbstractParser` (its parent class).
### Why are the changes needed?
- It's better to use higher classes if they fit for better extendability and maintenance.
- Univocity parser became inactive for the last three years, and we're missing bug fixes such as https://github.com/uniVocity/univocity-parsers/pull/533. We should probably leverage their interface, and implement it in Spark for bug fixes and further performance improvement. This is a basework.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing test cases should cover.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47221][SQL] Uses signatures from CsvParser to AbstractParser [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #45328: [SPARK-47221][SQL] Uses signatures from CsvParser to AbstractParser
URL: https://github.com/apache/spark/pull/45328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47221][SQL] Uses signatures from CsvParser to AbstractParser [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #45328:
URL: https://github.com/apache/spark/pull/45328#issuecomment-1970588243
+1, LGTM. Merging to master.
Thank you, @HyukjinKwon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org