You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/08 20:56:14 UTC

[GitHub] [airflow] ferruzzi commented on a change in pull request #21423: Refactor query status polling logic in EMRContainerHook

ferruzzi commented on a change in pull request #21423:
URL: https://github.com/apache/airflow/pull/21423#discussion_r802050744



##########
File path: airflow/providers/amazon/aws/hooks/emr.py
##########
@@ -114,6 +114,12 @@ class EmrContainerHook(AwsBaseHook):
         "CANCEL_PENDING",
     )
     SUCCESS_STATES = ("COMPLETED",)
+    TERMINAL_STATES = (
+        "COMPLETED",
+        "FAILED",
+        "CANCELLED",
+        "CANCEL_PENDING",

Review comment:
       Is "CANCEL_PENDING" really a terminal state?
   
   Looks good to me other than this question.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org