You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by ph...@apache.org on 2007/02/12 09:18:56 UTC
svn commit: r506365 - in /perl/modperl/trunk: Changes
t/response/TestAPI/request_rec.pm xs/maps/apache2_structures.map
Author: phred
Date: Mon Feb 12 00:18:55 2007
New Revision: 506365
URL: http://svn.apache.org/viewvc?view=rev&rev=506365
Log:
Make $r->the_request() writeable.
Change suggested by Alden DoRosario <ad...@chitika.com>
Change reviewed by Geoffrey Young <ge...@modperlcookbook.org>
Modified:
perl/modperl/trunk/Changes
perl/modperl/trunk/t/response/TestAPI/request_rec.pm
perl/modperl/trunk/xs/maps/apache2_structures.map
Modified: perl/modperl/trunk/Changes
URL: http://svn.apache.org/viewvc/perl/modperl/trunk/Changes?view=diff&rev=506365&r1=506364&r2=506365
==============================================================================
--- perl/modperl/trunk/Changes (original)
+++ perl/modperl/trunk/Changes Mon Feb 12 00:18:55 2007
@@ -12,6 +12,9 @@
=item 2.0.4-dev
+Make $r->the_request() writeable
+[Fred Moyer <fr...@redhotpenguin.com>]
+
fix ModPerl::RegistryCooker::read_script to handle all possible
errors, previously there was a case where Apache2::Const::OK was
returned on an error. [Eivind Eklund <ee...@gmail.com>]
Modified: perl/modperl/trunk/t/response/TestAPI/request_rec.pm
URL: http://svn.apache.org/viewvc/perl/modperl/trunk/t/response/TestAPI/request_rec.pm?view=diff&rev=506365&r1=506364&r2=506365
==============================================================================
--- perl/modperl/trunk/t/response/TestAPI/request_rec.pm (original)
+++ perl/modperl/trunk/t/response/TestAPI/request_rec.pm Mon Feb 12 00:18:55 2007
@@ -24,7 +24,7 @@
sub handler {
my $r = shift;
- plan $r, tests => 54;
+ plan $r, tests => 55;
#Apache2::RequestUtil->request($r); #PerlOptions +GlobalRequest takes care
my $gr = Apache2::RequestUtil->request;
@@ -126,6 +126,13 @@
ok t_cmp $r->the_request, "GET $base_uri$path_info?$args HTTP/1.0",
'$r->the_request';
+
+ {
+ my $new_request = "GET $base_uri$path_info?$args&foo=bar HTTP/1.0";
+ my $old_request = $r->the_request($new_request);
+ ok t_cmp $r->the_request, $new_request, '$r->the_request rw';
+ $r->the_request($old_request);
+ }
ok $r->filename;
Modified: perl/modperl/trunk/xs/maps/apache2_structures.map
URL: http://svn.apache.org/viewvc/perl/modperl/trunk/xs/maps/apache2_structures.map?view=diff&rev=506365&r1=506364&r2=506365
==============================================================================
--- perl/modperl/trunk/xs/maps/apache2_structures.map (original)
+++ perl/modperl/trunk/xs/maps/apache2_structures.map Mon Feb 12 00:18:55 2007
@@ -12,7 +12,7 @@
< next
< prev
< main
-< the_request
+ the_request
assbackwards
~ proxyreq
< header_only
Re: svn commit: r506365 - in /perl/modperl/trunk: Changes
t/response/TestAPI/request_rec.pm xs/maps/apache2_structures.map
Posted by Fred Moyer <fr...@taperfriendlymusic.org>.
On Mon, 12 Feb 2007, Geoffrey Young wrote:
> phred@apache.org wrote:
>> Author: phred
..
>> Change suggested by Alden DoRosario <ad...@chitika.com>
>> Change reviewed by Geoffrey Young <ge...@modperlcookbook.org>
>
> fred++
thanks :) I'm going to take a swing this week at the stacked handlers
issue reported a few months back (although it's probably over my head, but
that's what makes it fun).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r506365 - in /perl/modperl/trunk: Changes t/response/TestAPI/request_rec.pm
xs/maps/apache2_structures.map
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
phred@apache.org wrote:
> Author: phred
> Date: Mon Feb 12 00:18:55 2007
> New Revision: 506365
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=506365
> Log:
> Make $r->the_request() writeable.
> Change suggested by Alden DoRosario <ad...@chitika.com>
> Change reviewed by Geoffrey Young <ge...@modperlcookbook.org>
fred++
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org