[GitHub] spark issue #15575: [SPARK-18038] [SQL] Move output partitioning definition ...

[jaceklaskowski <gi...@git.apache.org>]

Github user jaceklaskowski commented on the issue:

    https://github.com/apache/spark/pull/15575
  
    I'm late with this, but just leaving it for future code reviewers...
    
    I think the change took the most extreme path where even such simple `outputPartitioning` as the one in `WindowExec` (see below) is currently part of the extension of `UnaryExecNode` while I think it should stay with `UnaryExecNode` and be overridden when the output partitioning is different. It's a kind of code duplication.
    
    ```
      override def outputPartitioning: Partitioning = child.outputPartitioning
    ```
    
    The above serves nothing but says _"I simply don't care what happens upstream"_.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org