[jira] Commented: (MAPREDUCE-2242) LinuxTaskController doesn't properly escape environment variables

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999833#comment-12999833 ] 

Hadoop QA commented on MAPREDUCE-2242:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12467507/mapreduce-2242.txt
  against trunk revision 1074251.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/39//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/39//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/39//console

This message is automatically generated.

> LinuxTaskController doesn't properly escape environment variables
> -----------------------------------------------------------------
>
>                 Key: MAPREDUCE-2242
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2242
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: task-controller
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: mapreduce-2242.txt
>
>
> LinuxTaskController currently just writes "export FOO=bar" pairs into taskjvm.sh, which fails if the value has multiple words or contains a space. This is causing TestDebugScriptWithLinuxTaskController among others to fail on trunk with the following message:
> {code}
> export: 1: -Dhadoop.tasklog.iscleanup: bad variable name
> {code}
> since it generated a taskjvm.sh including the following:
> {code}
> export HADOOP_CLIENT_OPTS=-Dhadoop.tasklog.taskid=attempt_20110104180935141_0001_m_000001_0 -Dhadoop.tasklog.iscleanup=false -Dhadoop.tasklog.totalLogFileSize=0
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira