[GitHub] [maven] cstamas commented on a diff in pull request #1040: [MNG-7720] Wrong build order of forked projects

["cstamas (via GitHub)" <gi...@apache.org>]

cstamas commented on code in PR #1040:
URL: https://github.com/apache/maven/pull/1040#discussion_r1128346697


##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleDependencyResolver.java:
##########
@@ -90,7 +90,11 @@ public LifecycleDependencyResolver(
 
     public static List<MavenProject> getProjects(MavenProject project, MavenSession session, boolean aggregator) {
         if (aggregator && project.getCollectedProjects() != null) {

Review Comment:
   I think it can be only on "top level" null (ie. some goal invocation not project being built), and once top level is not null, no child will have it null either... this is just a wild guess.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org