You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/01/13 13:46:01 UTC

[GitHub] [openwhisk-client-js] rabbah opened a new pull request #199: Handler a blocking/result response that is demoted to async.

rabbah opened a new pull request #199: Handler a blocking/result response that is demoted to async.
URL: https://github.com/apache/openwhisk-client-js/pull/199
 
 
   A blocking invoke that takes too long to complete may be demoted by the backend to an async invoke with the result being `{ activationId }` only. To preserve the behavior of the function, this patch will complete the promise with a `reject` should that happen.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-client-js] codecov-io edited a comment on issue #199: Handler a blocking/result response that is demoted to async.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #199: Handler a blocking/result response that is demoted to async.
URL: https://github.com/apache/openwhisk-client-js/pull/199#issuecomment-573719754
 
 
   # [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=h1) Report
   > Merging [#199](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk-client-js/commit/9f19b2e763c849c0e40162197ff8691573632d15?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/graphs/tree.svg?width=650&token=j2mPEx0Tkq&height=150&src=pr)](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #199      +/-   ##
   ==========================================
   + Coverage   99.27%   99.28%   +<.01%     
   ==========================================
     Files          14       14              
     Lines         414      417       +3     
   ==========================================
   + Hits          411      414       +3     
     Misses          3        3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [lib/actions.js](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/diff?src=pr&el=tree#diff-bGliL2FjdGlvbnMuanM=) | `100% <100%> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=footer). Last update [9f19b2e...47d35f6](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-client-js] codecov-io commented on issue #199: Handler a blocking/result response that is demoted to async.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #199: Handler a blocking/result response that is demoted to async.
URL: https://github.com/apache/openwhisk-client-js/pull/199#issuecomment-573719754
 
 
   # [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=h1) Report
   > Merging [#199](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk-client-js/commit/88ce0e286858eed89333814ddad6bf26b78630a2?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/graphs/tree.svg?width=650&token=j2mPEx0Tkq&height=150&src=pr)](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #199      +/-   ##
   ==========================================
   + Coverage   99.27%   99.28%   +0.01%     
   ==========================================
     Files          14       14              
     Lines         411      417       +6     
   ==========================================
   + Hits          408      414       +6     
     Misses          3        3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [lib/actions.js](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/diff?src=pr&el=tree#diff-bGliL2FjdGlvbnMuanM=) | `100% <100%> (ø)` | :arrow_up: |
   | [lib/client.js](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/diff?src=pr&el=tree#diff-bGliL2NsaWVudC5qcw==) | `98.88% <0%> (+0.03%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=footer). Last update [88ce0e2...47d35f6](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-client-js] rabbah merged pull request #199: Handle a blocking/result response that is demoted to async.

Posted by GitBox <gi...@apache.org>.
rabbah merged pull request #199: Handle a blocking/result response that is demoted to async.
URL: https://github.com/apache/openwhisk-client-js/pull/199
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-client-js] codecov-io edited a comment on issue #199: Handler a blocking/result response that is demoted to async.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #199: Handler a blocking/result response that is demoted to async.
URL: https://github.com/apache/openwhisk-client-js/pull/199#issuecomment-573719754
 
 
   # [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=h1) Report
   > Merging [#199](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk-client-js/commit/88ce0e286858eed89333814ddad6bf26b78630a2?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/graphs/tree.svg?width=650&token=j2mPEx0Tkq&height=150&src=pr)](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #199      +/-   ##
   ==========================================
   + Coverage   99.27%   99.28%   +0.01%     
   ==========================================
     Files          14       14              
     Lines         411      417       +6     
   ==========================================
   + Hits          408      414       +6     
     Misses          3        3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [lib/actions.js](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/diff?src=pr&el=tree#diff-bGliL2FjdGlvbnMuanM=) | `100% <100%> (ø)` | :arrow_up: |
   | [lib/client.js](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/diff?src=pr&el=tree#diff-bGliL2NsaWVudC5qcw==) | `98.88% <0%> (+0.03%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=footer). Last update [88ce0e2...47d35f6](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-client-js] rabbah commented on issue #199: Handle a blocking/result response that is demoted to async.

Posted by GitBox <gi...@apache.org>.
rabbah commented on issue #199: Handle a blocking/result response that is demoted to async.
URL: https://github.com/apache/openwhisk-client-js/pull/199#issuecomment-576327058
 
 
   Thanks for the reviews @upgle @purplecabbage @dgrove-oss.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-client-js] codecov-io edited a comment on issue #199: Handler a blocking/result response that is demoted to async.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #199: Handler a blocking/result response that is demoted to async.
URL: https://github.com/apache/openwhisk-client-js/pull/199#issuecomment-573719754
 
 
   # [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=h1) Report
   > Merging [#199](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk-client-js/commit/9f19b2e763c849c0e40162197ff8691573632d15?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/graphs/tree.svg?width=650&token=j2mPEx0Tkq&height=150&src=pr)](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #199      +/-   ##
   ==========================================
   + Coverage   99.27%   99.28%   +<.01%     
   ==========================================
     Files          14       14              
     Lines         414      417       +3     
   ==========================================
   + Hits          411      414       +3     
     Misses          3        3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [lib/actions.js](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/diff?src=pr&el=tree#diff-bGliL2FjdGlvbnMuanM=) | `100% <100%> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=footer). Last update [9f19b2e...47d35f6](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-client-js] codecov-io edited a comment on issue #199: Handler a blocking/result response that is demoted to async.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #199: Handler a blocking/result response that is demoted to async.
URL: https://github.com/apache/openwhisk-client-js/pull/199#issuecomment-573719754
 
 
   # [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=h1) Report
   > Merging [#199](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk-client-js/commit/88ce0e286858eed89333814ddad6bf26b78630a2?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/graphs/tree.svg?width=650&token=j2mPEx0Tkq&height=150&src=pr)](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #199      +/-   ##
   ==========================================
   + Coverage   99.27%   99.28%   +0.01%     
   ==========================================
     Files          14       14              
     Lines         411      417       +6     
   ==========================================
   + Hits          408      414       +6     
     Misses          3        3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [lib/actions.js](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/diff?src=pr&el=tree#diff-bGliL2FjdGlvbnMuanM=) | `100% <100%> (ø)` | :arrow_up: |
   | [lib/client.js](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/diff?src=pr&el=tree#diff-bGliL2NsaWVudC5qcw==) | `98.88% <0%> (+0.03%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=footer). Last update [88ce0e2...47d35f6](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-client-js] codecov-io edited a comment on issue #199: Handler a blocking/result response that is demoted to async.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #199: Handler a blocking/result response that is demoted to async.
URL: https://github.com/apache/openwhisk-client-js/pull/199#issuecomment-573719754
 
 
   # [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=h1) Report
   > Merging [#199](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk-client-js/commit/88ce0e286858eed89333814ddad6bf26b78630a2?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/graphs/tree.svg?width=650&token=j2mPEx0Tkq&height=150&src=pr)](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #199      +/-   ##
   ==========================================
   + Coverage   99.27%   99.28%   +0.01%     
   ==========================================
     Files          14       14              
     Lines         411      417       +6     
   ==========================================
   + Hits          408      414       +6     
     Misses          3        3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [lib/actions.js](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/diff?src=pr&el=tree#diff-bGliL2FjdGlvbnMuanM=) | `100% <100%> (ø)` | :arrow_up: |
   | [lib/client.js](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/diff?src=pr&el=tree#diff-bGliL2NsaWVudC5qcw==) | `98.88% <0%> (+0.03%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=footer). Last update [88ce0e2...47d35f6](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-client-js] codecov-io edited a comment on issue #199: Handler a blocking/result response that is demoted to async.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #199: Handler a blocking/result response that is demoted to async.
URL: https://github.com/apache/openwhisk-client-js/pull/199#issuecomment-573719754
 
 
   # [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=h1) Report
   > Merging [#199](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk-client-js/commit/88ce0e286858eed89333814ddad6bf26b78630a2?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/graphs/tree.svg?width=650&token=j2mPEx0Tkq&height=150&src=pr)](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #199      +/-   ##
   ==========================================
   + Coverage   99.27%   99.28%   +0.01%     
   ==========================================
     Files          14       14              
     Lines         411      417       +6     
   ==========================================
   + Hits          408      414       +6     
     Misses          3        3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [lib/actions.js](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/diff?src=pr&el=tree#diff-bGliL2FjdGlvbnMuanM=) | `100% <100%> (ø)` | :arrow_up: |
   | [lib/client.js](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/diff?src=pr&el=tree#diff-bGliL2NsaWVudC5qcw==) | `98.88% <0%> (+0.03%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=footer). Last update [88ce0e2...47d35f6](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-client-js] rabbah merged pull request #199: Handle a blocking/result response that is demoted to async.

Posted by GitBox <gi...@apache.org>.
rabbah merged pull request #199: Handle a blocking/result response that is demoted to async.
URL: https://github.com/apache/openwhisk-client-js/pull/199
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-client-js] upgle commented on a change in pull request #199: Handle a blocking/result response that is demoted to async.

Posted by GitBox <gi...@apache.org>.
upgle commented on a change in pull request #199: Handle a blocking/result response that is demoted to async.
URL: https://github.com/apache/openwhisk-client-js/pull/199#discussion_r368531128
 
 

 ##########
 File path: test/unit/actions.test.js
 ##########
 @@ -246,6 +246,25 @@ test('should invoke action to retrieve result', t => {
   })
 })
 
+test('should invoke action to retrieve result but request is demoted to async', t => {
+  t.plan(4)
+  const ns = '_'
+  const client = {}
+  const actions = new Actions(client)
+  const result = { activationId: '123456' }
+
+  client.request = (method, path, options) => {
+    t.is(method, 'POST')
+    t.is(path, `namespaces/${ns}/actions/12345`)
+    t.deepEqual(options.qs, { blocking: true })
+    return Promise.resolve(result)
+  }
+
+  return actions.invoke({ name: '12345', result: true, blocking: true }).catch(_result => {
 
 Review comment:
   LGTM 👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-client-js] codecov-io edited a comment on issue #199: Handler a blocking/result response that is demoted to async.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #199: Handler a blocking/result response that is demoted to async.
URL: https://github.com/apache/openwhisk-client-js/pull/199#issuecomment-573719754
 
 
   # [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=h1) Report
   > Merging [#199](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk-client-js/commit/88ce0e286858eed89333814ddad6bf26b78630a2?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/graphs/tree.svg?width=650&token=j2mPEx0Tkq&height=150&src=pr)](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #199      +/-   ##
   ==========================================
   + Coverage   99.27%   99.28%   +0.01%     
   ==========================================
     Files          14       14              
     Lines         411      417       +6     
   ==========================================
   + Hits          408      414       +6     
     Misses          3        3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [lib/actions.js](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/diff?src=pr&el=tree#diff-bGliL2FjdGlvbnMuanM=) | `100% <100%> (ø)` | :arrow_up: |
   | [lib/client.js](https://codecov.io/gh/apache/openwhisk-client-js/pull/199/diff?src=pr&el=tree#diff-bGliL2NsaWVudC5qcw==) | `98.88% <0%> (+0.03%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=footer). Last update [88ce0e2...47d35f6](https://codecov.io/gh/apache/openwhisk-client-js/pull/199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services