[GitHub] [dubbo] CrazyHZM commented on a diff in pull request #10356: feat: add mesh enable config and process url in mesh mode

[GitBox <gi...@apache.org>]

CrazyHZM commented on code in PR #10356:
URL: https://github.com/apache/dubbo/pull/10356#discussion_r928827030


##########
dubbo-common/src/main/java/org/apache/dubbo/config/ApplicationConfig.java:
##########
@@ -203,6 +204,12 @@ public class ApplicationConfig extends AbstractConfig {
 
     private Boolean enableEmptyProtection;
 
+    /**
+     * enable mesh mode
+     * @since 3.1.0
+     */
+    private Boolean meshEnable;

Review Comment:
   `meshEnable` should be the behavior of the consumer and should be placed in the configuration of the consumer level
   



##########
dubbo-common/src/main/java/org/apache/dubbo/config/AbstractReferenceConfig.java:
##########
@@ -82,6 +83,15 @@ public abstract class AbstractReferenceConfig extends AbstractInterfaceConfig {
      */
     protected String providedBy;
 
+    /**
+     * The service port of the provider, the default is the triple port of the {@link ProtocolConfig#port}.
+     * In mesh mode: by default, dubbo will think that the ports of the consumer and the provider are the same.
+     * If the tri port of the consumer and the provider are inconsistent, please specify the tri port of provider on the consumer side
+     *
+     * @since 3.1.0
+     */
+    protected Integer providerPort;

Review Comment:
   Need to consider the multi-port situation.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org