You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2014/09/24 15:50:25 UTC

svn commit: r1627323 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

Author: markt
Date: Wed Sep 24 13:50:24 2014
New Revision: 1627323

URL: http://svn.apache.org/r1627323
Log:
success defaults to true so no need to set to true during asynDispatch()

Modified:
    tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?rev=1627323&r1=1627322&r2=1627323&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Wed Sep 24 13:50:24 2014
@@ -306,7 +306,6 @@ public class CoyoteAdapter implements Ad
             }
 
             if (status==SocketStatus.TIMEOUT) {
-                success = true;
                 if (!asyncConImpl.timeout()) {
                     asyncConImpl.setErrorState(null, false);
                 }
@@ -373,7 +372,6 @@ public class CoyoteAdapter implements Ad
                     } finally {
                         request.getContext().unbind(false, oldCL);
                     }
-                    success = true;
                 } else if (readListener != null && status == SocketStatus.OPEN_READ) {
                     ClassLoader oldCL = null;
                     try {
@@ -396,7 +394,6 @@ public class CoyoteAdapter implements Ad
                     } finally {
                         request.getContext().unbind(false, oldCL);
                     }
-                    success = true;
                 }
             }
 
@@ -409,7 +406,6 @@ public class CoyoteAdapter implements Ad
             }
 
             if (request.isAsyncDispatching()) {
-                success = true;
                 connector.getService().getContainer().getPipeline().getFirst().invoke(request, response);
                 Throwable t = (Throwable) request.getAttribute(
                         RequestDispatcher.ERROR_EXCEPTION);



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org