You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2014/03/19 23:35:46 UTC
svn commit: r1579428 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt
Date: Wed Mar 19 22:35:46 2014
New Revision: 1579428
URL: http://svn.apache.org/r1579428
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1579428&r1=1579427&r2=1579428&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Mar 19 22:35:46 2014
@@ -57,6 +57,12 @@ PATCHES PROPOSED TO BACKPORT:
+1: markt
-1:
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56275
+ Fix memory leak if a Filter throws an exception during its destroy() method
+ http://people.apache.org/~markt/patches/2014-03-19-bug56275-tc6-v1.patch
+ +1: markt
+ -1:
+
PATCHES/ISSUES THAT ARE STALLED:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1579428 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Konstantin Kolinko <kn...@gmail.com>.
2014-03-20 23:58 GMT+04:00 Christopher Schultz <ch...@christopherschultz.net>:
> Mark,
>
> On 3/19/14, 6:35 PM, markt@apache.org wrote:
>> Author: markt
>> Date: Wed Mar 19 22:35:46 2014
>> New Revision: 1579428
>>
==============================================================================
>> --- tomcat/tc6.0.x/trunk/STATUS.txt (original)
>> +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Mar 19 22:35:46 2014
>>
>> +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56275
>> + Fix memory leak if a Filter throws an exception during its destroy() method
>> + http://people.apache.org/~markt/patches/2014-03-19-bug56275-tc6-v1.patch
>> + +1: markt
>> + -1:
>> +
>
> I can't seem to find the original patch against Tomcat 7.0 to ask about
> this, but I wanted to know who you removed the setFilterDef method
http://svn.apache.org/viewvc?view=revision&revision=1429172
> -- it
> seemed to provide the useful service of decommissioning any Filter that
> had already been started. Is that something that never actually happens?
>
That is a package-visible method, it is not part of the API.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1579428 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 20/03/2014 19:58, Christopher Schultz wrote:
> Mark,
>
> On 3/19/14, 6:35 PM, markt@apache.org wrote:
>> Author: markt Date: Wed Mar 19 22:35:46 2014 New Revision:
>> 1579428
>>
>> URL: http://svn.apache.org/r1579428 Log: Proposal
>>
>> Modified: tomcat/tc6.0.x/trunk/STATUS.txt
>>
>> Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:
>> http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1579428&r1=1579427&r2=1579428&view=diff
>>
>>
==============================================================================
>> --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++
>> tomcat/tc6.0.x/trunk/STATUS.txt Wed Mar 19 22:35:46 2014 @@ -57,6
>> +57,12 @@ PATCHES PROPOSED TO BACKPORT: +1: markt -1:
>>
>> +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56275 +
>> Fix memory leak if a Filter throws an exception during its
>> destroy() method +
>> http://people.apache.org/~markt/patches/2014-03-19-bug56275-tc6-v1.patch
>>
>>
+ +1: markt
>> + -1: +
>
> I can't seem to find the original patch against Tomcat 7.0 to ask
> about this,
The web interface is probably the easiest way to find that. (There are
actually several patches pulled into this one).
> but I wanted to know who you removed the setFilterDef method -- it
> seemed to provide the useful service of decommissioning any Filter
> that had already been started. Is that something that never
> actually happens?
Correct. It was never called.
Mark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJTK0jcAAoJEBDAHFovYFnn8l4P/2qT0nxVsjnxL8N99nLowbPa
eLa5MJJkAB2c2yumfdGChLudMt0eYO3R0GtWJLo2K/Xb8/xO8txfKh1D6jNJRFR2
os/+lzB21pFXiP0qpmZewFpI+RHpN4UoN3CHzsOnLotONK9tOLrtbgIZlnnk57QW
fSe86782UE+zHsAD/qH80Kkcnx9SQNmVO6e1onvIFSuroCHBx+cJg1Io0GPQf0BX
jCMAIlgoZ5h9KpSRH5RCC6I1XbfTw35lklT62NSHHeAeGwCuKkBTTHYufwKa4y0v
QE+o5UMox5glm6G7jEVMEuREx1DXj9RBIccq7XIgO+gW5hGBkzikaKz7cYVUwuNw
SzjtMUD7fFlpA6keFN3MTiBLhjlXDZA49lp5hRHzygm6SVmidarPINIIqD9WJxDc
sTNBt5vi1zxwRUS/qJhjDnqv+FNCcWWIEb2O5VnR5yTux5a7J6t+XpxHzcwAg31g
WOJoGYls5tpMUDAEvny0Jh6WLYDu3l2EBIl/Ysh3IXIKPSCoR6wb++EMsxzP2yJE
S3zp3ol07xiU1NPctyf00OGjb+7pAMG+qUsEu2+WrPWJzy+h49XYQSjzJDaY+G8F
aKPIRx1qLydBddIyM0zThgd0/a//rOUX7OMBvdvFijUrQxmT/WTn4OrM/d3aSCI2
PA9RuJp04dEN9cPl242B
=gssg
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1579428 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,
On 3/19/14, 6:35 PM, markt@apache.org wrote:
> Author: markt
> Date: Wed Mar 19 22:35:46 2014
> New Revision: 1579428
>
> URL: http://svn.apache.org/r1579428
> Log:
> Proposal
>
> Modified:
> tomcat/tc6.0.x/trunk/STATUS.txt
>
> Modified: tomcat/tc6.0.x/trunk/STATUS.txt
> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1579428&r1=1579427&r2=1579428&view=diff
> ==============================================================================
> --- tomcat/tc6.0.x/trunk/STATUS.txt (original)
> +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Mar 19 22:35:46 2014
> @@ -57,6 +57,12 @@ PATCHES PROPOSED TO BACKPORT:
> +1: markt
> -1:
>
> +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56275
> + Fix memory leak if a Filter throws an exception during its destroy() method
> + http://people.apache.org/~markt/patches/2014-03-19-bug56275-tc6-v1.patch
> + +1: markt
> + -1:
> +
I can't seem to find the original patch against Tomcat 7.0 to ask about
this, but I wanted to know who you removed the setFilterDef method -- it
seemed to provide the useful service of decommissioning any Filter that
had already been started. Is that something that never actually happens?
Thanks,
-chris