You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/05/28 02:03:45 UTC
Review Request 34739: Adding ChainedPathDetector into the GC executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34739/
-----------------------------------------------------------
Review request for Aurora, Brian Wickman and Zameer Manji.
Bugs: AURORA-1025
https://issues.apache.org/jira/browse/AURORA-1025
Repository: aurora
Description
-------
This has escaped the previous set of changes in AURORA-1025 to enable checkpoint dual-reading.
Extracted a method to faciliated unit testing as patching twitter.common.app is not fun.
Diffs
-----
src/main/python/apache/aurora/executor/bin/BUILD 25cc3d00ce7548ab54f1a2b857a3e6dbb1a85201
src/main/python/apache/aurora/executor/bin/gc_executor_main.py 9e6508493abda4fe47213c485073d62ac81a99e4
src/test/python/apache/aurora/executor/bin/BUILD 918a76933a640ea5bed369a49a0b762e1effff88
src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d6998783eea0cb880f2ab1274e6c74104e3bd13c
Diff: https://reviews.apache.org/r/34739/diff/
Testing
-------
./pants test.pytest --no-fast src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 34739: Adding ChainedPathDetector into the GC
executor.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34739/#review85479
-----------------------------------------------------------
Ship it!
Master (5724099) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 28, 2015, 12:03 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34739/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 12:03 a.m.)
>
>
> Review request for Aurora, Brian Wickman and Zameer Manji.
>
>
> Bugs: AURORA-1025
> https://issues.apache.org/jira/browse/AURORA-1025
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This has escaped the previous set of changes in AURORA-1025 to enable checkpoint dual-reading.
>
> Extracted a method to faciliated unit testing as patching twitter.common.app is not fun.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/BUILD 25cc3d00ce7548ab54f1a2b857a3e6dbb1a85201
> src/main/python/apache/aurora/executor/bin/gc_executor_main.py 9e6508493abda4fe47213c485073d62ac81a99e4
> src/test/python/apache/aurora/executor/bin/BUILD 918a76933a640ea5bed369a49a0b762e1effff88
> src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d6998783eea0cb880f2ab1274e6c74104e3bd13c
>
> Diff: https://reviews.apache.org/r/34739/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 34739: Adding ChainedPathDetector into the GC
executor.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34739/
-----------------------------------------------------------
(Updated May 28, 2015, 5:17 p.m.)
Review request for Aurora, Brian Wickman and Zameer Manji.
Changes
-------
Brian's comments.
Bugs: AURORA-1025
https://issues.apache.org/jira/browse/AURORA-1025
Repository: aurora
Description
-------
This has escaped the previous set of changes in AURORA-1025 to enable checkpoint dual-reading.
Extracted a method to faciliated unit testing as patching twitter.common.app is not fun.
Diffs (updated)
-----
src/main/python/apache/aurora/executor/bin/BUILD 25cc3d00ce7548ab54f1a2b857a3e6dbb1a85201
src/main/python/apache/aurora/executor/bin/gc_executor_main.py 9e6508493abda4fe47213c485073d62ac81a99e4
src/test/python/apache/aurora/executor/bin/BUILD 918a76933a640ea5bed369a49a0b762e1effff88
src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d6998783eea0cb880f2ab1274e6c74104e3bd13c
Diff: https://reviews.apache.org/r/34739/diff/
Testing
-------
./pants test.pytest --no-fast src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 34739: Adding ChainedPathDetector into the GC
executor.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On May 28, 2015, 5 p.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py, line 42
> > <https://reviews.apache.org/r/34739/diff/1/?file=973208#file973208line42>
> >
> > we tend to do assert mock.mock_calls == [mock.call(...)] to guard against "assret_called_with" typos.
> >
> > I understand in this case you want to just make sure that ThermosGCExecutor is called with a ChainedPathDetector.
> >
> > You can unwrap the arguments to the call instead:
> > assert len(mock.mock_calls) == 1
> > call = mock.mock_calls[0]
> > _, args, kwargs = call
> > assert len(args) == 1 and isinstance(args[0], ChainedPathDetector)
Don't have much preference here, done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34739/#review85568
-----------------------------------------------------------
On May 28, 2015, 12:03 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34739/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 12:03 a.m.)
>
>
> Review request for Aurora, Brian Wickman and Zameer Manji.
>
>
> Bugs: AURORA-1025
> https://issues.apache.org/jira/browse/AURORA-1025
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This has escaped the previous set of changes in AURORA-1025 to enable checkpoint dual-reading.
>
> Extracted a method to faciliated unit testing as patching twitter.common.app is not fun.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/BUILD 25cc3d00ce7548ab54f1a2b857a3e6dbb1a85201
> src/main/python/apache/aurora/executor/bin/gc_executor_main.py 9e6508493abda4fe47213c485073d62ac81a99e4
> src/test/python/apache/aurora/executor/bin/BUILD 918a76933a640ea5bed369a49a0b762e1effff88
> src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d6998783eea0cb880f2ab1274e6c74104e3bd13c
>
> Diff: https://reviews.apache.org/r/34739/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 34739: Adding ChainedPathDetector into the GC
executor.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34739/#review85568
-----------------------------------------------------------
Ship it!
feel free to ship as-is. provided an alternate suggestion for checking call but it's not a major improvement over what's already there.
src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py
<https://reviews.apache.org/r/34739/#comment137154>
we tend to do assert mock.mock_calls == [mock.call(...)] to guard against "assret_called_with" typos.
I understand in this case you want to just make sure that ThermosGCExecutor is called with a ChainedPathDetector.
You can unwrap the arguments to the call instead:
assert len(mock.mock_calls) == 1
call = mock.mock_calls[0]
_, args, kwargs = call
assert len(args) == 1 and isinstance(args[0], ChainedPathDetector)
- Brian Wickman
On May 28, 2015, 12:03 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34739/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 12:03 a.m.)
>
>
> Review request for Aurora, Brian Wickman and Zameer Manji.
>
>
> Bugs: AURORA-1025
> https://issues.apache.org/jira/browse/AURORA-1025
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This has escaped the previous set of changes in AURORA-1025 to enable checkpoint dual-reading.
>
> Extracted a method to faciliated unit testing as patching twitter.common.app is not fun.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/BUILD 25cc3d00ce7548ab54f1a2b857a3e6dbb1a85201
> src/main/python/apache/aurora/executor/bin/gc_executor_main.py 9e6508493abda4fe47213c485073d62ac81a99e4
> src/test/python/apache/aurora/executor/bin/BUILD 918a76933a640ea5bed369a49a0b762e1effff88
> src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d6998783eea0cb880f2ab1274e6c74104e3bd13c
>
> Diff: https://reviews.apache.org/r/34739/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 34739: Adding ChainedPathDetector into the GC
executor.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On May 28, 2015, 12:26 a.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py, lines 31-33
> > <https://reviews.apache.org/r/34739/diff/1/?file=973208#file973208line31>
> >
> > Consider using PyHamcrest here, specifically http://pyhamcrest.readthedocs.org/en/release-1.8/object_matchers/#hamcrest.core.core.isinstanceof.instance_of with http://pyhamcrest.readthedocs.org/en/release-1.8/integration/#module-hamcrest.library.integration.match_equality
Thanks for the pointer. I'll keep it in mind when I have a more substantial example to justify bringing a new test dependency.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34739/#review85478
-----------------------------------------------------------
On May 28, 2015, 12:03 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34739/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 12:03 a.m.)
>
>
> Review request for Aurora, Brian Wickman and Zameer Manji.
>
>
> Bugs: AURORA-1025
> https://issues.apache.org/jira/browse/AURORA-1025
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This has escaped the previous set of changes in AURORA-1025 to enable checkpoint dual-reading.
>
> Extracted a method to faciliated unit testing as patching twitter.common.app is not fun.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/BUILD 25cc3d00ce7548ab54f1a2b857a3e6dbb1a85201
> src/main/python/apache/aurora/executor/bin/gc_executor_main.py 9e6508493abda4fe47213c485073d62ac81a99e4
> src/test/python/apache/aurora/executor/bin/BUILD 918a76933a640ea5bed369a49a0b762e1effff88
> src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d6998783eea0cb880f2ab1274e6c74104e3bd13c
>
> Diff: https://reviews.apache.org/r/34739/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 34739: Adding ChainedPathDetector into the GC
executor.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34739/#review85478
-----------------------------------------------------------
Ship it!
src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py
<https://reviews.apache.org/r/34739/#comment137055>
Consider using PyHamcrest here, specifically http://pyhamcrest.readthedocs.org/en/release-1.8/object_matchers/#hamcrest.core.core.isinstanceof.instance_of with http://pyhamcrest.readthedocs.org/en/release-1.8/integration/#module-hamcrest.library.integration.match_equality
- Kevin Sweeney
On May 27, 2015, 5:03 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34739/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 5:03 p.m.)
>
>
> Review request for Aurora, Brian Wickman and Zameer Manji.
>
>
> Bugs: AURORA-1025
> https://issues.apache.org/jira/browse/AURORA-1025
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This has escaped the previous set of changes in AURORA-1025 to enable checkpoint dual-reading.
>
> Extracted a method to faciliated unit testing as patching twitter.common.app is not fun.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/BUILD 25cc3d00ce7548ab54f1a2b857a3e6dbb1a85201
> src/main/python/apache/aurora/executor/bin/gc_executor_main.py 9e6508493abda4fe47213c485073d62ac81a99e4
> src/test/python/apache/aurora/executor/bin/BUILD 918a76933a640ea5bed369a49a0b762e1effff88
> src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d6998783eea0cb880f2ab1274e6c74104e3bd13c
>
> Diff: https://reviews.apache.org/r/34739/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 34739: Adding ChainedPathDetector into the GC
executor.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34739/#review85475
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On May 27, 2015, 5:03 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34739/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 5:03 p.m.)
>
>
> Review request for Aurora, Brian Wickman and Zameer Manji.
>
>
> Bugs: AURORA-1025
> https://issues.apache.org/jira/browse/AURORA-1025
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This has escaped the previous set of changes in AURORA-1025 to enable checkpoint dual-reading.
>
> Extracted a method to faciliated unit testing as patching twitter.common.app is not fun.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/BUILD 25cc3d00ce7548ab54f1a2b857a3e6dbb1a85201
> src/main/python/apache/aurora/executor/bin/gc_executor_main.py 9e6508493abda4fe47213c485073d62ac81a99e4
> src/test/python/apache/aurora/executor/bin/BUILD 918a76933a640ea5bed369a49a0b762e1effff88
> src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d6998783eea0cb880f2ab1274e6c74104e3bd13c
>
> Diff: https://reviews.apache.org/r/34739/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>