You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "PDavid (via GitHub)" <gi...@apache.org> on 2025/02/03 08:56:56 UTC
[PR] HBASE-29026 Replace some deprecated calls [hbase]
PDavid opened a new pull request, #6658:
URL: https://github.com/apache/hbase/pull/6658
- Replaced the usage of the following deprecated methods:
- java.net.URLEncoder.encode(String) -> java.net.URLEncoder.encode(String, String)
- StringUtils.humanReadableInt(long) -> StringUtils.TraditionalBinaryPrefix.long2String(long, "", 1): For this a new static util method is introduced: org.apache.hadoop.hbase.util.Strings.humanReadableInt
- org.apache.hadoop.fs.FileSystem.getLength(Path) -> getFileStatus(Path).getLen()
- org.apache.hadoop.hbase.ServerName.getStartcode() -> org.apache.hadoop.hbase.ServerName.getStartCode()
- Also removed unused imports in the touched JSP files.
(cherry picked from commit cc52e795a2689aa6153c07fb37891b4bae7e0536)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29026 Replace some deprecated calls [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6658:
URL: https://github.com/apache/hbase/pull/6658#issuecomment-2630337373
This is the backport of https://github.com/apache/hbase/pull/6585 to branch-2.
I applied this with cherry-pick.
The only difference is that we cannot use `java.net.URLEncoder.encode(String, Charset)` because that API method was only introduced in Java 10 and `branch-2` should support running with Java 8. So we use `java.net.URLEncoder.encode(String, String)` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29026 Replace some deprecated calls [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6658:
URL: https://github.com/apache/hbase/pull/6658#issuecomment-2632119888
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 48s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 16s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 26s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 56s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 21s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 6s | | the patch passed |
| +1 :green_heart: | compile | 1m 25s | | the patch passed |
| +1 :green_heart: | javac | 1m 25s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 53s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 20s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 20s | | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 215m 5s | | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 18m 29s | | hbase-mapreduce in the patch passed. |
| | | 266m 9s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6658/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6658 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 328c8e0f1daa 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 332d7536e7801493e9ca1e61e7c9bf97d624b3f7 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6658/1/testReport/ |
| Max. process+thread count | 4417 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-mapreduce U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6658/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29026 Replace some deprecated calls [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6658:
URL: https://github.com/apache/hbase/pull/6658#issuecomment-2632074638
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 45s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 33s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 13s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 49s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 14s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 17s | | the patch passed |
| +1 :green_heart: | compile | 1m 11s | | the patch passed |
| +1 :green_heart: | javac | 1m 11s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 48s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 11s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 48s | | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 207m 27s | | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 12m 50s | | hbase-mapreduce in the patch passed. |
| | | 247m 35s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6658/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6658 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 56bf833d2bd0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 332d7536e7801493e9ca1e61e7c9bf97d624b3f7 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6658/1/testReport/ |
| Max. process+thread count | 4273 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-mapreduce U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6658/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29026 Replace some deprecated calls [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6658:
URL: https://github.com/apache/hbase/pull/6658#issuecomment-2631641144
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 48s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 6s | | branch-2 passed |
| +1 :green_heart: | compile | 4m 48s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 1m 19s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 3m 32s | | branch-2 passed |
| +1 :green_heart: | spotless | 1m 9s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 59s | | the patch passed |
| +1 :green_heart: | compile | 5m 11s | | the patch passed |
| +1 :green_heart: | javac | 5m 11s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 21s | | the patch passed |
| +1 :green_heart: | spotbugs | 3m 58s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 20m 24s | | Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 56s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 34s | | The patch does not generate ASF License warnings. |
| | | 55m 23s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6658/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6658 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 7206cdad11d9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 332d7536e7801493e9ca1e61e7c9bf97d624b3f7 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 79 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-mapreduce U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6658/1/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29026 Replace some deprecated calls [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain merged PR #6658:
URL: https://github.com/apache/hbase/pull/6658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org