You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2020/10/26 00:08:04 UTC

[spark] branch master updated: [SPARK-33234][INFRA] Generates SHA-512 using shasum

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new ce0ebf5  [SPARK-33234][INFRA] Generates SHA-512 using shasum
ce0ebf5 is described below

commit ce0ebf5f023b1d2230bbd4b9ffad294edef3bca7
Author: Emi <em...@gmail.com>
AuthorDate: Sun Oct 25 17:06:06 2020 -0700

    [SPARK-33234][INFRA] Generates SHA-512 using shasum
    
    ### What changes were proposed in this pull request?
    
    I am generating the SHA-512 using the standard shasum which also has a better output compared to GPG.
    
    ### Why are the changes needed?
    
    Which makes the hash much easier to verify for users that don't have GPG.
    
    Because an user having GPG can check the keys but an user without GPG will have a hard time validating the SHA-512 based on the 'pretty printed' format.
    
    Apache Spark is the only project where I've seen this format. Most other Apache projects have a one-line hash file.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    This patch assumes the build system has shasum (it should, but I can't test this).
    
    Closes #30123 from emilianbold/master.
    
    Authored-by: Emi <em...@gmail.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 dev/create-release/release-build.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dev/create-release/release-build.sh b/dev/create-release/release-build.sh
index c7fee13..240f4c8 100755
--- a/dev/create-release/release-build.sh
+++ b/dev/create-release/release-build.sh
@@ -182,8 +182,7 @@ if [[ "$1" == "package" ]]; then
   tar cvzf spark-$SPARK_VERSION.tgz --exclude spark-$SPARK_VERSION/.git spark-$SPARK_VERSION
   echo $GPG_PASSPHRASE | $GPG --passphrase-fd 0 --armour --output spark-$SPARK_VERSION.tgz.asc \
     --detach-sig spark-$SPARK_VERSION.tgz
-  echo $GPG_PASSPHRASE | $GPG --passphrase-fd 0 --print-md \
-    SHA512 spark-$SPARK_VERSION.tgz > spark-$SPARK_VERSION.tgz.sha512
+  shasum -a 512 spark-$SPARK_VERSION.tgz > spark-$SPARK_VERSION.tgz.sha512
   rm -rf spark-$SPARK_VERSION
 
   ZINC_PORT=3035


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org