You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tomee.apache.org by db...@apache.org on 2008/09/26 05:21:19 UTC

svn commit: r699162 - /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java

Author: dblevins
Date: Thu Sep 25 20:21:19 2008
New Revision: 699162

URL: http://svn.apache.org/viewvc?rev=699162&view=rev
Log:
Stronger error checking

Modified:
    openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java

Modified: openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java
URL: http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java?rev=699162&r1=699161&r2=699162&view=diff
==============================================================================
--- openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java (original)
+++ openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java Thu Sep 25 20:21:19 2008
@@ -778,7 +778,10 @@
      * 5.  If this fails, throw NoSuchProviderException
      */
     public <T extends ServiceInfo>T configureService(Class<? extends T> type, String serviceId, Properties declaredProperties, String providerId, String serviceType) throws OpenEJBException {
+        if (type == null) throw new NullPointerException("type is null");
+
         Class<? extends Service> serviceClass = types.get(type);
+        if (serviceClass == null) throw new OpenEJBException("Unsupported service info type: " + type.getName());
         Service service;
         try {
             service = serviceClass.newInstance();