You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by hisnamewasjaan <no...@github.com> on 2019/01/31 17:51:34 UTC
[jclouds/jclouds-site] Recommend use of repeatable payloads (#223)
## Uploading
Added extra info from @nacx recommending the use of repeatable payloads.
## Downloading
Removed some deprecated and non-existing api from description,
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-site/pull/223
-- Commit Summary --
* Recommend use of repeatable payloads
-- File Changes --
M start/blobstore.md (5)
-- Patch Links --
https://github.com/jclouds/jclouds-site/pull/223.patch
https://github.com/jclouds/jclouds-site/pull/223.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/223
Re: [jclouds/jclouds-site] Recommend use of repeatable payloads
(#223)
Posted by Andrew Gaul <no...@github.com>.
gaul commented on this pull request.
> be fine. Note that in S3, you must calculate the length ahead of time, since it doesn't support
chunked encoding.
+It is usually better to use a repeatable Payload like ByteSource instead of InputStream, since this allows parallel uploads and retrying on errors.
In markdown we use backticks to represent code. Like `InputStream` instead of InputStream.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/223#discussion_r252896497
Re: [jclouds/jclouds-site] Recommend use of repeatable payloads
(#223)
Posted by Andrew Gaul <no...@github.com>.
It would also be great to add a similar blurb in `BlobBuilder.java`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/223#issuecomment-459448184
Re: [jclouds/jclouds-site] Recommend use of repeatable payloads
(#223)
Posted by hisnamewasjaan <no...@github.com>.
hisnamewasjaan commented on this pull request.
> be fine. Note that in S3, you must calculate the length ahead of time, since it doesn't support
chunked encoding.
+It is usually better to use a repeatable Payload like ByteSource instead of InputStream, since this allows parallel uploads and retrying on errors.
Got it, thx :)
Commit amended.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/223#discussion_r252949418
Re: [jclouds/jclouds-site] Recommend use of repeatable payloads
(#223)
Posted by hisnamewasjaan <no...@github.com>.
hisnamewasjaan commented on this pull request.
> be fine. Note that in S3, you must calculate the length ahead of time, since it doesn't support
chunked encoding.
+It is usually better to use a repeatable Payload like ByteSource instead of InputStream, since this allows parallel uploads and retrying on errors.
Sorry, I dont follow? Annotate what?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/223#discussion_r252856463
Re: [jclouds/jclouds-site] Recommend use of repeatable payloads
(#223)
Posted by Andrew Gaul <no...@github.com>.
gaul requested changes on this pull request.
> be fine. Note that in S3, you must calculate the length ahead of time, since it doesn't support
chunked encoding.
+It is usually better to use a repeatable Payload like ByteSource instead of InputStream, since this allows parallel uploads and retrying on errors.
Could you annotate as `ByteSource` and `InputStream`?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/223#pullrequestreview-198735278
Re: [jclouds/jclouds-site] Recommend use of repeatable payloads
(#223)
Posted by Andrew Gaul <no...@github.com>.
Thank you for your contribution @hisnamewasjaan!
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/223#issuecomment-459629101