You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Weston M. Price (Created) (JIRA)" <ji...@apache.org> on 2011/12/15 16:14:30 UTC
[jira] [Created] (QPID-3688) AMQDestination and children should
conform to the JavaBean pattern
AMQDestination and children should conform to the JavaBean pattern
------------------------------------------------------------------
Key: QPID-3688
URL: https://issues.apache.org/jira/browse/QPID-3688
Project: Qpid
Issue Type: Improvement
Components: Java Client
Affects Versions: 0.12
Environment: All platforms.
Reporter: Weston M. Price
Fix For: Future
In order to support deploying and managing AMQDestination's in JEE application servers, conformance to the JavaBean design pattern is preferred as many appellation servers have their own management infrastructure for supporting Administrative objects that require, at the very least, a default constructor to create and bootstrap the destination into the server address space.
The AMQDestination and children classes should support this to make JEE integration easier and more consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3688) AMQDestination and children should
conform to the JavaBean pattern
Posted by "Robbie Gemmell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180480#comment-13180480 ]
Robbie Gemmell commented on QPID-3688:
--------------------------------------
Ok, I had thought that initially, but how does it know what properties are to be set to what values...properties files? (In case it doesnt show I have no experience of application servers :P)
> AMQDestination and children should conform to the JavaBean pattern
> ------------------------------------------------------------------
>
> Key: QPID-3688
> URL: https://issues.apache.org/jira/browse/QPID-3688
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.12
> Environment: All platforms.
> Reporter: Weston M. Price
> Assignee: Rajith Attapattu
> Fix For: Future
>
> Attachments: QPID-3688.patch
>
>
> In order to support deploying and managing AMQDestination's in JEE application servers, conformance to the JavaBean design pattern is preferred as many appellation servers have their own management infrastructure for supporting Administrative objects that require, at the very least, a default constructor to create and bootstrap the destination into the server address space.
> The AMQDestination and children classes should support this to make JEE integration easier and more consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3688) AMQDestination and children should
conform to the JavaBean pattern
Posted by "Weston M. Price (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180484#comment-13180484 ]
Weston M. Price commented on QPID-3688:
---------------------------------------
It's a good question actually. In terms of JCA, there is an ra.xml file that is used as a 'template' by the application server. Listed in the ra.xml file are the properties an AdminObject supports. Something along the lines of:
<adminobject>
<adminobject-interface>javax.jms.Destination</adminobject-interface>
<adminobject-class> org.apache.qpid.ra.admin.QpidDestinationProxy</adminobject-class>
<config-property>
<config-property-name>destinationAddress </config-property-name>
<config-property-type>java.lang.String </config-property-type>
</config-property>
<config-property>
<config-property-name>destinationType</config-property-name>
<config-property-type>java.lang.String </config-property-type>
</config-property>
</adminobject>
So, based on this definition, when you configure/deploy an admin object, the app server knows what properties are exposed and what to set after constructing the AdminObject, which of course is the reason a default constructor is required since the app server depends on the AdminObject conforming to the JavaBean specification.
> AMQDestination and children should conform to the JavaBean pattern
> ------------------------------------------------------------------
>
> Key: QPID-3688
> URL: https://issues.apache.org/jira/browse/QPID-3688
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.12
> Environment: All platforms.
> Reporter: Weston M. Price
> Assignee: Rajith Attapattu
> Fix For: Future
>
> Attachments: QPID-3688.patch
>
>
> In order to support deploying and managing AMQDestination's in JEE application servers, conformance to the JavaBean design pattern is preferred as many appellation servers have their own management infrastructure for supporting Administrative objects that require, at the very least, a default constructor to create and bootstrap the destination into the server address space.
> The AMQDestination and children classes should support this to make JEE integration easier and more consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3688) AMQDestination and children should
conform to the JavaBean pattern
Posted by "Robbie Gemmell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180496#comment-13180496 ]
Robbie Gemmell commented on QPID-3688:
--------------------------------------
Weston, that makes things clearer thanks:)
Rajith, I would probably just use a single setter for ADDR and BURL Strings and use the existing support code to distinguish them, given thats how it works everywhere else. Possibly changing the method to something more generic like 'setDestinationString'.
> AMQDestination and children should conform to the JavaBean pattern
> ------------------------------------------------------------------
>
> Key: QPID-3688
> URL: https://issues.apache.org/jira/browse/QPID-3688
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.12
> Environment: All platforms.
> Reporter: Weston M. Price
> Assignee: Rajith Attapattu
> Fix For: Future
>
> Attachments: QPID-3688.patch
>
>
> In order to support deploying and managing AMQDestination's in JEE application servers, conformance to the JavaBean design pattern is preferred as many appellation servers have their own management infrastructure for supporting Administrative objects that require, at the very least, a default constructor to create and bootstrap the destination into the server address space.
> The AMQDestination and children classes should support this to make JEE integration easier and more consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3688) AMQDestination and children should
conform to the JavaBean pattern
Posted by "Robbie Gemmell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180465#comment-13180465 ]
Robbie Gemmell commented on QPID-3688:
--------------------------------------
I agree that the destinations should be immutable, and given what they store they really should be just getting created based on Strings (as e.g the session.createQueue() or JNDI properties file methods would)
I take it the intention is that the protected default constructors would only be used by subclassing the various destination objects?
The new AMQDestination constructor added seems like it should possibly use the 'default syntax' value located in the class rather than just assuming it is ADDR, and the 'setAddressString' method could then set _destSyntax if it is ever used or throw an exception if the two conflicted.
I'm possibly missing something, but if the calling code can be altered such that it is able to use the 'setAddressString' method, whats stopping it being made to use the existing String constructors for the objects?
> AMQDestination and children should conform to the JavaBean pattern
> ------------------------------------------------------------------
>
> Key: QPID-3688
> URL: https://issues.apache.org/jira/browse/QPID-3688
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.12
> Environment: All platforms.
> Reporter: Weston M. Price
> Assignee: Rajith Attapattu
> Fix For: Future
>
> Attachments: QPID-3688.patch
>
>
> In order to support deploying and managing AMQDestination's in JEE application servers, conformance to the JavaBean design pattern is preferred as many appellation servers have their own management infrastructure for supporting Administrative objects that require, at the very least, a default constructor to create and bootstrap the destination into the server address space.
> The AMQDestination and children classes should support this to make JEE integration easier and more consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3688) AMQDestination and children should
conform to the JavaBean pattern
Posted by "Weston M. Price (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180471#comment-13180471 ]
Weston M. Price commented on QPID-3688:
---------------------------------------
The issue is that in JEE environments we have no control over the calling code as the application server is constructing the object and requires a no-arg constructor. Once the object is constructed, properties are set and then the object is bound into JNDI. Again, the app server is managing this entire process so we have no control over how the object is constructed.
> AMQDestination and children should conform to the JavaBean pattern
> ------------------------------------------------------------------
>
> Key: QPID-3688
> URL: https://issues.apache.org/jira/browse/QPID-3688
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.12
> Environment: All platforms.
> Reporter: Weston M. Price
> Assignee: Rajith Attapattu
> Fix For: Future
>
> Attachments: QPID-3688.patch
>
>
> In order to support deploying and managing AMQDestination's in JEE application servers, conformance to the JavaBean design pattern is preferred as many appellation servers have their own management infrastructure for supporting Administrative objects that require, at the very least, a default constructor to create and bootstrap the destination into the server address space.
> The AMQDestination and children classes should support this to make JEE integration easier and more consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3688) AMQDestination and children should
conform to the JavaBean pattern
Posted by "Rajith Attapattu (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rajith Attapattu resolved QPID-3688.
------------------------------------
Resolution: Fixed
Fix Version/s: (was: Future)
0.15
> AMQDestination and children should conform to the JavaBean pattern
> ------------------------------------------------------------------
>
> Key: QPID-3688
> URL: https://issues.apache.org/jira/browse/QPID-3688
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.12
> Environment: All platforms.
> Reporter: Weston M. Price
> Assignee: Rajith Attapattu
> Labels: possibly_complete
> Fix For: 0.15
>
> Attachments: QPID-3688.patch
>
>
> In order to support deploying and managing AMQDestination's in JEE application servers, conformance to the JavaBean design pattern is preferred as many appellation servers have their own management infrastructure for supporting Administrative objects that require, at the very least, a default constructor to create and bootstrap the destination into the server address space.
> The AMQDestination and children classes should support this to make JEE integration easier and more consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3688) AMQDestination and children should
conform to the JavaBean pattern
Posted by "Rajith Attapattu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180506#comment-13180506 ]
Rajith Attapattu commented on QPID-3688:
----------------------------------------
Agreed, that make sense.
> AMQDestination and children should conform to the JavaBean pattern
> ------------------------------------------------------------------
>
> Key: QPID-3688
> URL: https://issues.apache.org/jira/browse/QPID-3688
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.12
> Environment: All platforms.
> Reporter: Weston M. Price
> Assignee: Rajith Attapattu
> Fix For: Future
>
> Attachments: QPID-3688.patch
>
>
> In order to support deploying and managing AMQDestination's in JEE application servers, conformance to the JavaBean design pattern is preferred as many appellation servers have their own management infrastructure for supporting Administrative objects that require, at the very least, a default constructor to create and bootstrap the destination into the server address space.
> The AMQDestination and children classes should support this to make JEE integration easier and more consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3688) AMQDestination and children should
conform to the JavaBean pattern
Posted by "Rajith Attapattu (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rajith Attapattu reassigned QPID-3688:
--------------------------------------
Assignee: Rajith Attapattu
> AMQDestination and children should conform to the JavaBean pattern
> ------------------------------------------------------------------
>
> Key: QPID-3688
> URL: https://issues.apache.org/jira/browse/QPID-3688
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.12
> Environment: All platforms.
> Reporter: Weston M. Price
> Assignee: Rajith Attapattu
> Fix For: Future
>
>
> In order to support deploying and managing AMQDestination's in JEE application servers, conformance to the JavaBean design pattern is preferred as many appellation servers have their own management infrastructure for supporting Administrative objects that require, at the very least, a default constructor to create and bootstrap the destination into the server address space.
> The AMQDestination and children classes should support this to make JEE integration easier and more consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3688) AMQDestination and children should
conform to the JavaBean pattern
Posted by "Rajith Attapattu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180492#comment-13180492 ]
Rajith Attapattu commented on QPID-3688:
----------------------------------------
"The new AMQDestination constructor added seems like it should possibly use the 'default syntax' value located in the class rather than just assuming it is ADDR, and the 'setAddressString' method could then set _destSyntax if it is ever used or throw an exception if the two conflicted."
I think we could do that and possibly add a getter and setter for BURL as well.
Robbie, I believe Weston addressed the other concern you had.
> AMQDestination and children should conform to the JavaBean pattern
> ------------------------------------------------------------------
>
> Key: QPID-3688
> URL: https://issues.apache.org/jira/browse/QPID-3688
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.12
> Environment: All platforms.
> Reporter: Weston M. Price
> Assignee: Rajith Attapattu
> Fix For: Future
>
> Attachments: QPID-3688.patch
>
>
> In order to support deploying and managing AMQDestination's in JEE application servers, conformance to the JavaBean design pattern is preferred as many appellation servers have their own management infrastructure for supporting Administrative objects that require, at the very least, a default constructor to create and bootstrap the destination into the server address space.
> The AMQDestination and children classes should support this to make JEE integration easier and more consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3688) AMQDestination and children should
conform to the JavaBean pattern
Posted by "Weston M. Price (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180510#comment-13180510 ]
Weston M. Price commented on QPID-3688:
---------------------------------------
'Weston, that makes things clearer thanks'
My pleasure.
I am in agreement as well with the above comments.
> AMQDestination and children should conform to the JavaBean pattern
> ------------------------------------------------------------------
>
> Key: QPID-3688
> URL: https://issues.apache.org/jira/browse/QPID-3688
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.12
> Environment: All platforms.
> Reporter: Weston M. Price
> Assignee: Rajith Attapattu
> Fix For: Future
>
> Attachments: QPID-3688.patch
>
>
> In order to support deploying and managing AMQDestination's in JEE application servers, conformance to the JavaBean design pattern is preferred as many appellation servers have their own management infrastructure for supporting Administrative objects that require, at the very least, a default constructor to create and bootstrap the destination into the server address space.
> The AMQDestination and children classes should support this to make JEE integration easier and more consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3688) AMQDestination and children should
conform to the JavaBean pattern
Posted by "Robbie Gemmell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3688:
---------------------------------
Labels: possibly_complete (was: )
> AMQDestination and children should conform to the JavaBean pattern
> ------------------------------------------------------------------
>
> Key: QPID-3688
> URL: https://issues.apache.org/jira/browse/QPID-3688
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.12
> Environment: All platforms.
> Reporter: Weston M. Price
> Assignee: Rajith Attapattu
> Labels: possibly_complete
> Fix For: Future
>
> Attachments: QPID-3688.patch
>
>
> In order to support deploying and managing AMQDestination's in JEE application servers, conformance to the JavaBean design pattern is preferred as many appellation servers have their own management infrastructure for supporting Administrative objects that require, at the very least, a default constructor to create and bootstrap the destination into the server address space.
> The AMQDestination and children classes should support this to make JEE integration easier and more consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3688) AMQDestination and children should
conform to the JavaBean pattern
Posted by "Rajith Attapattu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rajith Attapattu updated QPID-3688:
-----------------------------------
Attachment: QPID-3688.patch
This patch doesn't change the AMQDestination into a Java bean as I'm not sure if we should allow fields like routing-key, exchange-name etc modifiable via setter methods.
Infact the Destination implementations should be immutable once a BURL or an Address string is set.
However in order to satisfy the app server situation, I think it's a reasonable compromise to introduce a default constructor and a setter method for BURL and Address String. The rest of the fields should be immutable.
> AMQDestination and children should conform to the JavaBean pattern
> ------------------------------------------------------------------
>
> Key: QPID-3688
> URL: https://issues.apache.org/jira/browse/QPID-3688
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.12
> Environment: All platforms.
> Reporter: Weston M. Price
> Assignee: Rajith Attapattu
> Fix For: Future
>
> Attachments: QPID-3688.patch
>
>
> In order to support deploying and managing AMQDestination's in JEE application servers, conformance to the JavaBean design pattern is preferred as many appellation servers have their own management infrastructure for supporting Administrative objects that require, at the very least, a default constructor to create and bootstrap the destination into the server address space.
> The AMQDestination and children classes should support this to make JEE integration easier and more consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org