You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/05/27 15:54:02 UTC
[kudu-CR] [rpc] small cleanup on RemoteMethod, RpcContext
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15989
Change subject: [rpc] small cleanup on RemoteMethod, RpcContext
......................................................................
[rpc] small cleanup on RemoteMethod, RpcContext
Avoid copying strings in methods
{RemoteMethod,RpcContext}::{method_name,service_name}.
Change-Id: I64531206b2eee8792372c989c48d430a7a62b865
---
M src/kudu/rpc/remote_method.h
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/15989/1
--
To view, visit http://gerrit.cloudera.org:8080/15989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64531206b2eee8792372c989c48d430a7a62b865
Gerrit-Change-Number: 15989
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [rpc] small cleanup on RemoteMethod, RpcContext
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15989 )
Change subject: [rpc] small cleanup on RemoteMethod, RpcContext
......................................................................
[rpc] small cleanup on RemoteMethod, RpcContext
Avoid copying strings in methods
{RemoteMethod,RpcContext}::{method_name,service_name}.
Change-Id: I64531206b2eee8792372c989c48d430a7a62b865
Reviewed-on: http://gerrit.cloudera.org:8080/15989
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/remote_method.h
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
3 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I64531206b2eee8792372c989c48d430a7a62b865
Gerrit-Change-Number: 15989
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [rpc] small cleanup on RemoteMethod, RpcContext
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15989 )
Change subject: [rpc] small cleanup on RemoteMethod, RpcContext
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64531206b2eee8792372c989c48d430a7a62b865
Gerrit-Change-Number: 15989
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 27 May 2020 16:20:09 +0000
Gerrit-HasComments: No