You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Richard van der Hoff (JIRA)" <ji...@codehaus.org> on 2006/08/23 02:50:49 UTC
[jira] Created: (MECLIPSE-151) Incorrect name for test sources jars
Incorrect name for test sources jars
------------------------------------
Key: MECLIPSE-151
URL: http://jira.codehaus.org/browse/MECLIPSE-151
Project: Maven 2.x Eclipse Plugin
Issue Type: Bug
Affects Versions: 2.2
Reporter: Richard van der Hoff
The eclipse plugin currently sets the source attachment of dependencies on test-jars (as created by the test-jar goal of the jar plugin) to the same as that of the main jar.
To fix, we need to check the classifier of dependencies when finding sources, and if it is "tests", use "test-sources" rather than "sources" for the classifier on the sources jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-151) Incorrect name for test sources jars
Posted by "Richard van der Hoff (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-151?page=all ]
Richard van der Hoff updated MECLIPSE-151:
------------------------------------------
Attachment: maven-eclipse-plugin.patch
This also affects version 2.3. Here's a patch, with unit tests, which fixes it.
> Incorrect name for test sources jars
> ------------------------------------
>
> Key: MECLIPSE-151
> URL: http://jira.codehaus.org/browse/MECLIPSE-151
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Richard van der Hoff
> Attachments: maven-eclipse-plugin.patch
>
>
> The eclipse plugin currently sets the source attachment of dependencies on test-jars (as created by the test-jar goal of the jar plugin) to the same as that of the main jar.
> To fix, we need to check the classifier of dependencies when finding sources, and if it is "tests", use "test-sources" rather than "sources" for the classifier on the sources jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-151) Incorrect name for test sources jars
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MECLIPSE-151:
-------------------------------
Fix Version/s: (was: 2.4)
2.5
> Incorrect name for test sources jars
> ------------------------------------
>
> Key: MECLIPSE-151
> URL: http://jira.codehaus.org/browse/MECLIPSE-151
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Richard van der Hoff
> Assignee: fabrizio giustina
> Fix For: 2.5
>
> Attachments: maven-eclipse-plugin.patch
>
>
> The eclipse plugin currently sets the source attachment of dependencies on test-jars (as created by the test-jar goal of the jar plugin) to the same as that of the main jar.
> To fix, we need to check the classifier of dependencies when finding sources, and if it is "tests", use "test-sources" rather than "sources" for the classifier on the sources jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-151) Incorrect name for test sources
jars
Posted by "Richard van der Hoff (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_100853 ]
Richard van der Hoff commented on MECLIPSE-151:
-----------------------------------------------
To reiterate what Max said: please do consider this for 2.4, as (a) the bug is a complete nuisance, and if you don't fix it, we'll have to patch it locally again; (b) the patch is pretty small; (c) there are some lovely tests for it...
> Incorrect name for test sources jars
> ------------------------------------
>
> Key: MECLIPSE-151
> URL: http://jira.codehaus.org/browse/MECLIPSE-151
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Richard van der Hoff
> Assignee: fabrizio giustina
> Fix For: 2.5
>
> Attachments: maven-eclipse-plugin.patch
>
>
> The eclipse plugin currently sets the source attachment of dependencies on test-jars (as created by the test-jar goal of the jar plugin) to the same as that of the main jar.
> To fix, we need to check the classifier of dependencies when finding sources, and if it is "tests", use "test-sources" rather than "sources" for the classifier on the sources jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-151) Incorrect name for test sources
jars
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101206 ]
Brian Fox commented on MECLIPSE-151:
------------------------------------
I applied the patches from this issue and MECLIPSE-287 to a branch since I had to rework all the tests to avoid conflicts.
https://svn.apache.org/repos/asf/maven/plugins/branches/maven-eclipse-plugin-151-287
If you can make this work with a patch off of that branch, then we can get it in.
> Incorrect name for test sources jars
> ------------------------------------
>
> Key: MECLIPSE-151
> URL: http://jira.codehaus.org/browse/MECLIPSE-151
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Richard van der Hoff
> Assignee: fabrizio giustina
> Fix For: 2.4
>
> Attachments: maven-eclipse-plugin.patch
>
>
> The eclipse plugin currently sets the source attachment of dependencies on test-jars (as created by the test-jar goal of the jar plugin) to the same as that of the main jar.
> To fix, we need to check the classifier of dependencies when finding sources, and if it is "tests", use "test-sources" rather than "sources" for the classifier on the sources jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-151) Incorrect name for test sources jars
Posted by "Max Bowsher (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Max Bowsher updated MECLIPSE-151:
---------------------------------
Attachment: eclipse-151-287-more.patch
Here is a patch which:
- fixes naming in test project-33 pom.xml
- changes ordering in expected/.classpath files to what is produced
- fixes MECLIPSE-287
In addition to this patch, you must also:
svn mv \
src/test/resources/m2repo/maven/maven-core/98.0/maven-core-98.0-tests-sources.jar \
src/test/resources/m2repo/maven/maven-core/98.0/maven-core-98.0-test-sources.jar
Please also delete the project-35 test, as it is redundant with project-33, and contains a misleadingly unnecessary downloadSources configuration.
> Incorrect name for test sources jars
> ------------------------------------
>
> Key: MECLIPSE-151
> URL: http://jira.codehaus.org/browse/MECLIPSE-151
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Richard van der Hoff
> Assignee: fabrizio giustina
> Fix For: 2.4
>
> Attachments: eclipse-151-287-more.patch, maven-eclipse-plugin.patch
>
>
> The eclipse plugin currently sets the source attachment of dependencies on test-jars (as created by the test-jar goal of the jar plugin) to the same as that of the main jar.
> To fix, we need to check the classifier of dependencies when finding sources, and if it is "tests", use "test-sources" rather than "sources" for the classifier on the sources jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-151) Incorrect name for test sources
jars
Posted by "Max Bowsher (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_100829 ]
Max Bowsher commented on MECLIPSE-151:
--------------------------------------
Could the above reallocation of this issue from 2.4 to 2.5 be reconsidered? I suggest this because it has a patch, which is fairly small, and furthermore, the fix for regression bug MECLIPSE-287 is likely to require a subset of the same changes in any case.
Indeed, now that I review it, the regression test that I have attached to MECLIPSE-287 (which also requires that this issue be fixed, for the test to pass - see other issue for explanation why) is in fact more-or-less identical to the regression test included in the patch attached to this issue.
> Incorrect name for test sources jars
> ------------------------------------
>
> Key: MECLIPSE-151
> URL: http://jira.codehaus.org/browse/MECLIPSE-151
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Richard van der Hoff
> Assignee: fabrizio giustina
> Fix For: 2.5
>
> Attachments: maven-eclipse-plugin.patch
>
>
> The eclipse plugin currently sets the source attachment of dependencies on test-jars (as created by the test-jar goal of the jar plugin) to the same as that of the main jar.
> To fix, we need to check the classifier of dependencies when finding sources, and if it is "tests", use "test-sources" rather than "sources" for the classifier on the sources jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-151) Incorrect name for test sources jars
Posted by "fabrizio giustina (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-151?page=all ]
fabrizio giustina updated MECLIPSE-151:
---------------------------------------
Assignee: fabrizio giustina
Fix Version/s: 2.4
patch look fine, I will apply it as soon as other tests are fixed (tests don't work properly on some platforms at the moment)
> Incorrect name for test sources jars
> ------------------------------------
>
> Key: MECLIPSE-151
> URL: http://jira.codehaus.org/browse/MECLIPSE-151
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Richard van der Hoff
> Assigned To: fabrizio giustina
> Fix For: 2.4
>
> Attachments: maven-eclipse-plugin.patch
>
>
> The eclipse plugin currently sets the source attachment of dependencies on test-jars (as created by the test-jar goal of the jar plugin) to the same as that of the main jar.
> To fix, we need to check the classifier of dependencies when finding sources, and if it is "tests", use "test-sources" rather than "sources" for the classifier on the sources jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MECLIPSE-151) Incorrect name for test sources jars
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox closed MECLIPSE-151.
------------------------------
Assignee: Brian Fox (was: fabrizio giustina)
Resolution: Fixed
> Incorrect name for test sources jars
> ------------------------------------
>
> Key: MECLIPSE-151
> URL: http://jira.codehaus.org/browse/MECLIPSE-151
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Richard van der Hoff
> Assignee: Brian Fox
> Fix For: 2.4
>
> Attachments: eclipse-151-287-more.patch, maven-eclipse-plugin.patch
>
>
> The eclipse plugin currently sets the source attachment of dependencies on test-jars (as created by the test-jar goal of the jar plugin) to the same as that of the main jar.
> To fix, we need to check the classifier of dependencies when finding sources, and if it is "tests", use "test-sources" rather than "sources" for the classifier on the sources jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-151) Incorrect name for test sources
jars
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101205 ]
Brian Fox commented on MECLIPSE-151:
------------------------------------
I'm ready to release 2.4 so I took a look at this and MECLIPSE-287. Something doesn't seem right with the tests in this patch. It is expecting the sources to be downloaded, but I don't see this set in any of the tests. I tried updating the test pom and still have issues. This is the .classpath I get:
{noformat}
<classpath>
<classpathentry kind="output" path="target/classes"/>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
<classpathentry kind="var" path="M2_REPO/maven/maven-core/98.0/maven-core-98.0-tests.jar"/>
</classpath>
{noformat}
Also note, the patch contains project27, but this is now taken. I needed to update everything to project35.
> Incorrect name for test sources jars
> ------------------------------------
>
> Key: MECLIPSE-151
> URL: http://jira.codehaus.org/browse/MECLIPSE-151
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Richard van der Hoff
> Assignee: fabrizio giustina
> Fix For: 2.4
>
> Attachments: maven-eclipse-plugin.patch
>
>
> The eclipse plugin currently sets the source attachment of dependencies on test-jars (as created by the test-jar goal of the jar plugin) to the same as that of the main jar.
> To fix, we need to check the classifier of dependencies when finding sources, and if it is "tests", use "test-sources" rather than "sources" for the classifier on the sources jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-151) Incorrect name for test sources jars
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MECLIPSE-151:
-------------------------------
Fix Version/s: (was: 2.5)
2.4
> Incorrect name for test sources jars
> ------------------------------------
>
> Key: MECLIPSE-151
> URL: http://jira.codehaus.org/browse/MECLIPSE-151
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Richard van der Hoff
> Assignee: fabrizio giustina
> Fix For: 2.4
>
> Attachments: maven-eclipse-plugin.patch
>
>
> The eclipse plugin currently sets the source attachment of dependencies on test-jars (as created by the test-jar goal of the jar plugin) to the same as that of the main jar.
> To fix, we need to check the classifier of dependencies when finding sources, and if it is "tests", use "test-sources" rather than "sources" for the classifier on the sources jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira