You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/03/22 15:54:32 UTC

Review Request 70278: Added an << operator for ResourceQuantities.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70278/
-----------------------------------------------------------

Review request for mesos and Meng Zhu.


Repository: mesos


Description
-------

This follows the same output format as Resources.


Diffs
-----

  src/common/resource_quantities.hpp e85ff4f3c9201a5409f292b0a43b99c73341a3d0 
  src/common/resource_quantities.cpp d9042e9c0fa5e90e619470830ca430a31b2ce5bc 
  src/tests/resource_quantities_tests.cpp 441b48950e9adde92758cbbd09814c69bf6e6ca3 


Diff: https://reviews.apache.org/r/70278/diff/1/


Testing
-------

Added a test.


Thanks,

Benjamin Mahler

Re: Review Request 70278: Added an << operator for ResourceQuantities.

Posted by Meng Zhu <mz...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70278/#review213961
-----------------------------------------------------------


Ship it!




- Meng Zhu


On March 22, 2019, 8:54 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70278/
> -----------------------------------------------------------
> 
> (Updated March 22, 2019, 8:54 a.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This follows the same output format as Resources.
> 
> 
> Diffs
> -----
> 
>   src/common/resource_quantities.hpp e85ff4f3c9201a5409f292b0a43b99c73341a3d0 
>   src/common/resource_quantities.cpp d9042e9c0fa5e90e619470830ca430a31b2ce5bc 
>   src/tests/resource_quantities_tests.cpp 441b48950e9adde92758cbbd09814c69bf6e6ca3 
> 
> 
> Diff: https://reviews.apache.org/r/70278/diff/1/
> 
> 
> Testing
> -------
> 
> Added a test.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>