You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/02/19 20:45:57 UTC
[GitHub] [samza] mynameborat opened a new pull request #1282: SAMZA-2463:
Duplicate firings of processing timers
mynameborat opened a new pull request #1282: SAMZA-2463: Duplicate firings of processing timers
URL: https://github.com/apache/samza/pull/1282
**Symptom**: Duplicate firing of processing timers
**Cause**: In EpochTimeScheduler, the `removeReadyTimers` returns the timers that are ready to be fired and also remove them from local book-keeping. We operate on the SetView returned by entrySet() to remove the timers. Since the iterator of the SetView is weakly consistent, there is possibilities in timers surviving the remove and results in duplicate timers being fired.
**Changes**: Remove the keys from the local book keeping map directly instead of using the `KeySet()` and `removeAll()`
**Tests**: Tested using the Nexmark beam benchmark test suite. Will explore a way to unit test this change and follow it up on a separate PR.
**API Changes**: None
**Upgrade Instructions**: None
**Usage Instructions**: None
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] mynameborat merged pull request #1282: SAMZA-2463:
Duplicate firings of processing timers
Posted by GitBox <gi...@apache.org>.
mynameborat merged pull request #1282: SAMZA-2463: Duplicate firings of processing timers
URL: https://github.com/apache/samza/pull/1282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services