You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/15 09:32:59 UTC
[GitHub] [incubator-devlake] likyh opened a new pull request, #2203: github pr task refactor
likyh opened a new pull request, #2203:
URL: https://github.com/apache/incubator-devlake/pull/2203
# Summary
1. replace db with dal in the pr task of github.
2. add e2e test for repo
3. add connectionId for repo
### Does this close any open issues?
related #1980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #2203: github pr task refactor
Posted by GitBox <gi...@apache.org>.
klesh commented on code in PR #2203:
URL: https://github.com/apache/incubator-devlake/pull/2203#discussion_r899066736
##########
plugins/github/models/migrationscripts/init_schema_20220611.go:
##########
@@ -131,7 +131,7 @@ func (u *InitSchemas) Up(ctx context.Context, db *gorm.DB) error {
}
func (*InitSchemas) Version() uint64 {
- return 20220611000001
+ return 20220612000001
Review Comment:
Please update file name as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #2203: github pr task refactor
Posted by GitBox <gi...@apache.org>.
klesh merged PR #2203:
URL: https://github.com/apache/incubator-devlake/pull/2203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #2203: github pr task refactor
Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #2203:
URL: https://github.com/apache/incubator-devlake/pull/2203#discussion_r899198219
##########
plugins/github/models/migrationscripts/init_schema_20220611.go:
##########
@@ -131,7 +131,7 @@ func (u *InitSchemas) Up(ctx context.Context, db *gorm.DB) error {
}
func (*InitSchemas) Version() uint64 {
- return 20220611000001
+ return 20220612000001
Review Comment:
It will be fixed here: https://github.com/apache/incubator-devlake/pull/2211/files#diff-24615817c70ecbcf16f004e7e2bc3fffad3263f82678df2c48170c85c189cce9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org