You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/12/12 12:22:00 UTC

[GitHub] [solr] gerlowskija opened a new pull request #455: SOLR-15745: Convert corestatus APIs to annotations

gerlowskija opened a new pull request #455:
URL: https://github.com/apache/solr/pull/455

# Description

Solr has historically supported two frameworks for definings its v2
APIs: a JSON-based 'apispec' framework, and a more modern replacement
that relies on JAX-RS-like annotations to specify endpoints and
parameters.

The community is in the process of migrating to the annotation based
approach, but many apispec APIs remain.

# Solution

This commit converts GET /v2/cores and GET /v2/cores/coreName over to
the annotation framework.

# Tests

See V2CoresAPIMappingTest

# Checklist

Please review the following and check all that apply:

- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [x] I have added tests for my changes.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] epugh commented on a change in pull request #455: SOLR-15745: Convert corestatus APIs to annotations

Posted by GitBox <gi...@apache.org>.

epugh commented on a change in pull request #455:
URL: https://github.com/apache/solr/pull/455#discussion_r767749071



##########
File path: solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java
##########
@@ -411,6 +413,8 @@ void call() throws Exception {
   public Collection<Api> getApis() {
     final List<Api> apis = Lists.newArrayList(coreAdminHandlerApi.getApis());
     // Only some core-admin APIs use the v2 AnnotatedApi framework

Review comment:
       is the above comment still true.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] gerlowskija merged pull request #455: SOLR-15745: Convert corestatus APIs to annotations

Posted by GitBox <gi...@apache.org>.

gerlowskija merged pull request #455:
URL: https://github.com/apache/solr/pull/455


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] gerlowskija commented on a change in pull request #455: SOLR-15745: Convert corestatus APIs to annotations

Posted by GitBox <gi...@apache.org>.

gerlowskija commented on a change in pull request #455:
URL: https://github.com/apache/solr/pull/455#discussion_r771816411



##########
File path: solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java
##########
@@ -411,6 +413,8 @@ void call() throws Exception {
   public Collection<Api> getApis() {
     final List<Api> apis = Lists.newArrayList(coreAdminHandlerApi.getApis());
     // Only some core-admin APIs use the v2 AnnotatedApi framework

Review comment:
       Yep, even after this PR there are the `cores.core.Commands` and the cores.core.Commands.split` apispec files.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org