You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/19 20:07:24 UTC

[GitHub] [helix] narendly commented on pull request #1292: Remove closed ZKConnectionManager from connection manager pool

narendly commented on pull request #1292:
URL: https://github.com/apache/helix/pull/1292#issuecomment-676635566


   HI @manick02  -
   
   Thanks for the pull request. Here are a few things to keep in mind:
   
   - Please check off the boxes if you've completed the item.
   - Please clarify which module you ran the test on. For this particular change, I think we would need to run tests on zookeeper-api, helix-core, and helix-rest modules.
   - In general, every logical change must be accompanied by a corresponding test. Do you think you could add a test testing the change in logic?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org