You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Vladimir Ozerov (JIRA)" <ji...@apache.org> on 2016/02/01 08:52:40 UTC
[jira] [Comment Edited] (IGNITE-2507)
GridBinaryMarshaller#pushContext() uses ThreadLocal inefficiently.
[ https://issues.apache.org/jira/browse/IGNITE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125902#comment-15125902 ]
Vladimir Ozerov edited comment on IGNITE-2507 at 2/1/16 7:52 AM:
-----------------------------------------------------------------
Root cause of this issue is call to ThreadLocal.remove(). Instead, we should call ThreadLocal.set(null).
was (Author: vozerov):
Root cause of this isssue is call to ThreadLocal.remove(). Instead, we should call ThreadLocal.set(null).
> GridBinaryMarshaller#pushContext() uses ThreadLocal inefficiently.
> ------------------------------------------------------------------
>
> Key: IGNITE-2507
> URL: https://issues.apache.org/jira/browse/IGNITE-2507
> Project: Ignite
> Issue Type: Sub-task
> Components: general
> Affects Versions: 1.5.0.final
> Reporter: Ilya Lantukh
> Assignee: Ilya Lantukh
> Fix For: 1.6
>
>
> {noformat}
> java.lang.ThreadLocal$ThreadLocalMap.set(ThreadLocal, Object)
> java.lang.ThreadLocal$ThreadLocalMap.access$100(ThreadLocal$ThreadLocalMap, ThreadLocal, Object)
> java.lang.ThreadLocal.setInitialValue()
> java.lang.ThreadLocal.get()
> org.apache.ignite.internal.binary.GridBinaryMarshaller.pushContext(BinaryContext)
> org.apache.ignite.internal.binary.GridBinaryMarshaller.unmarshal(byte[], ClassLoader)
> {noformat}
> It creates hundreds of ThreadLocalMap$Entry instances. Need to find out whether BinaryContext can be stored more efficiently.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)