You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2021/11/10 18:49:53 UTC
[GitHub] [samza] cameronlee314 commented on a change in pull request #1555: Improve GRADLE build Performance
cameronlee314 commented on a change in pull request #1555:
URL: https://github.com/apache/samza/pull/1555#discussion_r746877284
##########
File path: build.gradle
##########
@@ -102,6 +102,10 @@ rat {
}
allprojects {
+ tasks.withType(JavaCompile).configureEach {
+ options.fork = true
+ }
+
Review comment:
Minor: Could you please use 2 spaces for indentation instead of 4? Just for consistency with the rest of the file.
##########
File path: build.gradle
##########
@@ -102,6 +102,10 @@ rat {
}
allprojects {
+ tasks.withType(JavaCompile).configureEach {
Review comment:
Minor: Does `tasks.withType(JavaCompile).configureEach` do something different than `tasks.withType(JavaCompile)`? https://docs.gradle.org/5.2.1/dsl/org.gradle.api.tasks.compile.JavaCompile.html doesn't have the `configureEach`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org