You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "David Van Couvering (JIRA)" <de...@db.apache.org> on 2006/04/10 19:23:58 UTC
[jira] Created: (DERBY-1198) jdbc/StatementTest.java uses SQLState
directly
jdbc/StatementTest.java uses SQLState directly
----------------------------------------------
Key: DERBY-1198
URL: http://issues.apache.org/jira/browse/DERBY-1198
Project: Derby
Type: Bug
Components: Test
Reporter: David Van Couvering
Priority: Trivial
During inspection for another problem, I noticed that StatementTest.java still uses SQLState.NO_CURRENT_CONNECTION. SQLState is a private interface and should not be used in our tests. This test should instead use "08003" or better yet use the new SQLStateConstants class in the functiontests/util package, e.g. SQLStateConstants.CONNECTION_EXCEPTION_CONNECTION_DOES_NOT_EXIST
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1198) jdbc/StatementTest.java uses SQLState
directly
Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1198?page=all ]
Kristian Waagan updated DERBY-1198:
-----------------------------------
Attachment: derby-1198-rmimport.diff
'derby-1198-rmimport.diff' removes an unused import in StatementTest. After the new SQLStateConstants was introduced, SQLState is no longer used in the test.
I discovered this when planning to close the issue. After this tiny patch has been applied, the issue can be closed.
> jdbc/StatementTest.java uses SQLState directly
> ----------------------------------------------
>
> Key: DERBY-1198
> URL: http://issues.apache.org/jira/browse/DERBY-1198
> Project: Derby
> Type: Bug
> Components: Test
> Reporter: David Van Couvering
> Priority: Trivial
> Fix For: 10.2.0.0
> Attachments: derby-1198-rmimport.diff
>
> During inspection for another problem, I noticed that StatementTest.java still uses SQLState.NO_CURRENT_CONNECTION. SQLState is a private interface and should not be used in our tests. This test should instead use "08003" or better yet use the new SQLStateConstants class in the functiontests/util package, e.g. SQLStateConstants.CONNECTION_EXCEPTION_CONNECTION_DOES_NOT_EXIST
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1198) jdbc/StatementTest.java uses
SQLState directly
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1198?page=comments#action_12375345 ]
Knut Anders Hatlen commented on DERBY-1198:
-------------------------------------------
Thanks for the patch, Kristian. Committed revision 395573.
> jdbc/StatementTest.java uses SQLState directly
> ----------------------------------------------
>
> Key: DERBY-1198
> URL: http://issues.apache.org/jira/browse/DERBY-1198
> Project: Derby
> Type: Bug
> Components: Test
> Reporter: David Van Couvering
> Priority: Trivial
> Fix For: 10.2.0.0
> Attachments: derby-1198-rmimport.diff
>
> During inspection for another problem, I noticed that StatementTest.java still uses SQLState.NO_CURRENT_CONNECTION. SQLState is a private interface and should not be used in our tests. This test should instead use "08003" or better yet use the new SQLStateConstants class in the functiontests/util package, e.g. SQLStateConstants.CONNECTION_EXCEPTION_CONNECTION_DOES_NOT_EXIST
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-1198) jdbc/StatementTest.java uses SQLState
directly
Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1198?page=all ]
Kristian Waagan closed DERBY-1198:
----------------------------------
Ran the jdbc40 suite again to confirm the fix didn't break anything. Run passed.
> jdbc/StatementTest.java uses SQLState directly
> ----------------------------------------------
>
> Key: DERBY-1198
> URL: http://issues.apache.org/jira/browse/DERBY-1198
> Project: Derby
> Type: Bug
> Components: Test
> Reporter: David Van Couvering
> Priority: Trivial
> Fix For: 10.2.0.0
> Attachments: derby-1198-rmimport.diff
>
> During inspection for another problem, I noticed that StatementTest.java still uses SQLState.NO_CURRENT_CONNECTION. SQLState is a private interface and should not be used in our tests. This test should instead use "08003" or better yet use the new SQLStateConstants class in the functiontests/util package, e.g. SQLStateConstants.CONNECTION_EXCEPTION_CONNECTION_DOES_NOT_EXIST
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-1198) jdbc/StatementTest.java uses SQLState
directly
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1198?page=all ]
David Van Couvering resolved DERBY-1198:
----------------------------------------
Fix Version: 10.2.0.0
Resolution: Fixed
Checked in revision 395484
> jdbc/StatementTest.java uses SQLState directly
> ----------------------------------------------
>
> Key: DERBY-1198
> URL: http://issues.apache.org/jira/browse/DERBY-1198
> Project: Derby
> Type: Bug
> Components: Test
> Reporter: David Van Couvering
> Priority: Trivial
> Fix For: 10.2.0.0
>
> During inspection for another problem, I noticed that StatementTest.java still uses SQLState.NO_CURRENT_CONNECTION. SQLState is a private interface and should not be used in our tests. This test should instead use "08003" or better yet use the new SQLStateConstants class in the functiontests/util package, e.g. SQLStateConstants.CONNECTION_EXCEPTION_CONNECTION_DOES_NOT_EXIST
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira