[GitHub] [pulsar] zymap commented on a change in pull request #5613: [PIP-50] Package management implementation (part-1)

[GitBox <gi...@apache.org>]

zymap commented on a change in pull request #5613: [PIP-50] Package management implementation (part-1)
URL: https://github.com/apache/pulsar/pull/5613#discussion_r361472621
 
 

 ##########
 File path: pulsar-package-manager/src/main/java/org/apache/pulsar/packages/manager/exception/PackageMetaAlreadyExistsException.java
 ##########
 @@ -0,0 +1,30 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pulsar.packages.manager.exception;
+
+/**
+ * Thrown package metadata already existAsync exceptions.
+ */
+public class PackageMetaAlreadyExistsException extends PackageException {
 
 Review comment:
   Because the metadata and package are two files, delete a package that needs to delete metadata as well. Delete package and metadata are two operations and I can not promise after deleting package the metadata will delete successfully. 
   If one of the delete operations was failed and the user ignores the error and uploads the same package again, the metadata or the package may be already existent.
   Do you have some advice?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services