You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by el...@apache.org on 2022/12/20 22:50:25 UTC
[superset] branch master updated: fix(chart-list): Hide 'Dashboards added to' column. (#22475)
This is an automated email from the ASF dual-hosted git repository.
elizabeth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 7a94f3afc6 fix(chart-list): Hide 'Dashboards added to' column. (#22475)
7a94f3afc6 is described below
commit 7a94f3afc611993324cb507b23a8f8c320ac76cd
Author: Cody Leff <co...@preset.io>
AuthorDate: Tue Dec 20 22:50:18 2022 +0000
fix(chart-list): Hide 'Dashboards added to' column. (#22475)
---
.../cypress/integration/chart_list/list.test.ts | 14 ++++++++------
superset-frontend/src/views/CRUD/chart/ChartList.tsx | 1 +
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts b/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts
index c64effd411..29b3d16b14 100644
--- a/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts
+++ b/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts
@@ -58,7 +58,7 @@ describe('Charts list', () => {
cy.preserveLogin();
});
- describe('Cross-referenced dashboards', () => {
+ describe.skip('Cross-referenced dashboards', () => {
beforeEach(() => {
cy.createSampleDashboards([0, 1, 2, 3]);
cy.createSampleCharts([0]);
@@ -105,6 +105,8 @@ describe('Charts list', () => {
describe('list mode', () => {
before(() => {
+ cy.createSampleDashboards([0, 1, 2, 3]);
+ cy.createSampleCharts([0]);
visitChartList();
setGridMode('list');
});
@@ -114,11 +116,11 @@ describe('Charts list', () => {
cy.getBySel('sort-header').eq(1).contains('Chart');
cy.getBySel('sort-header').eq(2).contains('Visualization type');
cy.getBySel('sort-header').eq(3).contains('Dataset');
- cy.getBySel('sort-header').eq(4).contains('Dashboards added to');
- cy.getBySel('sort-header').eq(5).contains('Modified by');
- cy.getBySel('sort-header').eq(6).contains('Last modified');
- cy.getBySel('sort-header').eq(7).contains('Created by');
- cy.getBySel('sort-header').eq(8).contains('Actions');
+ // cy.getBySel('sort-header').eq(4).contains('Dashboards added to');
+ cy.getBySel('sort-header').eq(4).contains('Modified by');
+ cy.getBySel('sort-header').eq(5).contains('Last modified');
+ cy.getBySel('sort-header').eq(6).contains('Created by');
+ cy.getBySel('sort-header').eq(7).contains('Actions');
});
it('should sort correctly in list mode', () => {
diff --git a/superset-frontend/src/views/CRUD/chart/ChartList.tsx b/superset-frontend/src/views/CRUD/chart/ChartList.tsx
index d3b480479c..1bbaddb411 100644
--- a/superset-frontend/src/views/CRUD/chart/ChartList.tsx
+++ b/superset-frontend/src/views/CRUD/chart/ChartList.tsx
@@ -401,6 +401,7 @@ function ChartList(props: ChartListProps) {
accessor: 'dashboards',
disableSortBy: true,
size: 'xxl',
+ hidden: true,
},
{
Cell: ({