You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Johan Oskarsson (JIRA)" <ji...@apache.org> on 2009/06/22 00:34:07 UTC
[jira] Created: (CASSANDRA-249) Add unit test for gms package
Add unit test for gms package
-----------------------------
Key: CASSANDRA-249
URL: https://issues.apache.org/jira/browse/CASSANDRA-249
Project: Cassandra
Issue Type: Improvement
Reporter: Johan Oskarsson
Priority: Trivial
Fix For: 0.4
The gms package is in need of unit testing according to http://hudson.zones.apache.org/hudson/job/Cassandra/115/cobertura/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-249) Add unit test for gms package
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated CASSANDRA-249:
--------------------------------------
Attachment: CASSANDRA-249.patch
This patch adds unit tests for a few of the gms classes, mainly failure detector and related. This version of the test uses mockito for mocking, since a lot of the gms classes are tightly coupled and hard to test otherwise. See CASSANDRA-250 for discussion about mockito.
> Add unit test for gms package
> -----------------------------
>
> Key: CASSANDRA-249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-249
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: CASSANDRA-249.patch
>
>
> The gms package is in need of unit testing according to http://hudson.zones.apache.org/hudson/job/Cassandra/115/cobertura/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-249) Add unit test for gms package
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-249:
-------------------------------------
Component/s: Core
> Add unit test for gms package
> -----------------------------
>
> Key: CASSANDRA-249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-249
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: CASSANDRA-249.patch
>
>
> The gms package is in need of unit testing according to http://hudson.zones.apache.org/hudson/job/Cassandra/115/cobertura/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-249) Add unit test for gms package
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724630#action_12724630 ]
Jonathan Ellis commented on CASSANDRA-249:
------------------------------------------
After commit I ran the system tests and discovered that this patch introduced an infinite recursion. Checked in fix immediately in r788781 since the trunk was broken.
Apologies for not running system tests _first_. But I think this illustrates my point in CASSANDRA-250 about the relative usefulness of unit tests and system tests nicely.
> Add unit test for gms package
> -----------------------------
>
> Key: CASSANDRA-249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-249
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: CASSANDRA-249.patch
>
>
> The gms package is in need of unit testing according to http://hudson.zones.apache.org/hudson/job/Cassandra/115/cobertura/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-249) Add unit test for gms package
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724849#action_12724849 ]
Hudson commented on CASSANDRA-249:
----------------------------------
Integrated in Cassandra #121 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/121/])
r/m refactor from that caused infinite recursion. patch by jbellis
some gms tests. patch by johano; reviewed by jbellis for
> Add unit test for gms package
> -----------------------------
>
> Key: CASSANDRA-249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-249
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: CASSANDRA-249.patch
>
>
> The gms package is in need of unit testing according to http://hudson.zones.apache.org/hudson/job/Cassandra/115/cobertura/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.