You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/04 14:26:09 UTC
[GitHub] [tvm] leandron opened a new issue #9187: [Tracking issue] Quantized TFLite operators
leandron opened a new issue #9187:
URL: https://github.com/apache/tvm/issues/9187
As part of https://github.com/apache/tvm/pull/9165, we recently enabled support for quantized operators in the TFLite frontend "unary element-wise" function, that does generic support for a few operators.
That opens the door for more operators to be supported easily, just pending the addition of tests and logically _unlocking_ the conditional block that is keeping the quantised version of the operator to be unsupported. See the example as implemented in https://github.com/apache/tvm/pull/9165.
This is a tracking issue for new unary element-wise operators to be supported:
- [ ] `GREATER`
- [ ] `EQUAL`
- [ ] `CEIL`
- [ ] `ROUND`
- [ ] `FLOOR`
- [ ] `EXP`
- [ ] `LOG`
- [ ] `SIN`
- [ ] `TAN`
- [ ] `COS`
- [ ] `SQRT`
- [ ] `SQRT`
- [x] `RSQRT` #9165 by @ophirfrish
- [ ] `NEG`
For each operator above, there are actions to be taken:
1. Remove the conditional block `if self.is_quantized(op): ...`
2. Implement unit tests
#9165 can be used as an example.
Resources:
* TFlite frontend: https://github.com/apache/tvm/blob/main/python/tvm/relay/frontend/tflite.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on issue #9187: [Tracking issue] Quantized TFLite operators
Posted by GitBox <gi...@apache.org>.
leandron commented on issue #9187:
URL: https://github.com/apache/tvm/issues/9187#issuecomment-1066563500
> Hi @leandron I am interested in getting to know the source code better. Is the list of operators up to date? I might try implementing the GREATER operator using https://github.com/apache/tvm/pull/9165 as a template. Thanks!
Sorry I missed your message. I've just updated the list of operator.
To your question: yes, you can use #9165 as a template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] psigillito commented on issue #9187: [Tracking issue] Quantized TFLite operators
Posted by GitBox <gi...@apache.org>.
psigillito commented on issue #9187:
URL: https://github.com/apache/tvm/issues/9187#issuecomment-1021564614
Hi @leandron I am interested in getting to know the source code better. Is the list of operators up to date? I might try implementing the GREATER operator using #9165 as a template. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] onkar-sima-ai commented on issue #9187: [Tracking issue] Quantized TFLite operators
Posted by GitBox <gi...@apache.org>.
onkar-sima-ai commented on issue #9187:
URL: https://github.com/apache/tvm/issues/9187#issuecomment-964246656
Hi @leandron can you please update this issue and if possible review the PR for qunatized SIN operator?
I have followed the instruction in this issue to write the test cases.
Please let me know if I need to do any changes.
Thanks for posting, Happy to contribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on issue #9187: [Tracking issue] Quantized TFLite operators
Posted by GitBox <gi...@apache.org>.
leandron commented on issue #9187:
URL: https://github.com/apache/tvm/issues/9187#issuecomment-964278070
> Hi @leandron can you please update this issue and if possible review the PR for qunatized SIN operator? I have followed the instruction in this issue to write the test cases.
>
> Please let me know if I need to do any changes. Thanks for posting, Happy to contribute.
Done! thanks @onkar-sima-ai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org