You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 13:35:08 UTC
[PR] test(metrics): deepen Apache proxy collector coverage [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3354:
URL: https://github.com/apache/rocketmq-dashboard/pull/3354
## Summary
Extends the existing `ApacheRocketMqProxyMetricsCollectorTest` (3 to 6 tests) to pin down the proxy collector contract.
Added cases:
- `supports` accepts Apache and vendor-less instances with a name and endpoint, and rejects cloud vendors, missing endpoints, and null instances;
- `metricKeys` exposes only `proxy.availability`;
- discovery iterates every cluster while skipping clusters without proxies, collecting a reachable sample from the remaining cluster.
## Why
The collector feeds native Apache proxy availability alerting; only probe/discovery-failure branches were covered before.
## Testing
`mvn -B test -Dtest=ApacheRocketMqProxyMetricsCollectorTest` — 6/6 pass; checkstyle (validate) clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(metrics): deepen Apache proxy collector coverage [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3354: test(metrics): deepen Apache proxy collector coverage
URL: https://github.com/apache/rocketmq-dashboard/pull/3354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org